samples: sockets: big_http_download: Increase stack size by 128 bytes #23487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfalcon
added
area: Networking
Trivial
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
|
The previous bump was just in the beginning of January: b3ef46e . Not sure who would be to contact on that, so pinging @nashif and @andrewboie regarding the situation that Zephyr's stack usage grows constantly, visible with naked eye. |
Merged
Without it, the sample crashes for qemu_x86 with: [00:00:03.080,000] <err> os: Page fault at address 0x7275632f (error code 0x10) [00:00:03.080,000] <err> os: Linear address not present in page tables [00:00:03.080,000] <err> os: PDPTE: Non-present ... Increase by reasonable, but small amount, to keep watching stack usage growth trends in Zephyr. Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
pfalcon
force-pushed
the
big_http_download-bump-stack
branch
from
7b078a1
to
a421b56
Compare
jukkar
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it, the sample crashes for qemu_x86 with:
[00:00:03.080,000] os: Page fault at address 0x7275632f (error code 0x10)
[00:00:03.080,000] os: Linear address not present in page tables
[00:00:03.080,000] os: PDPTE: Non-present
...
Increase by reasonable, but small amount, to keep watching stack usage
growth trends in Zephyr.
Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org