-
Notifications
You must be signed in to change notification settings - Fork 8k
Add support for STM32L432KC and Nucleo L432KC board #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d3d75e6
to
237dc4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists (and sub-lists) need a blank line before and after the lists, so add a blank line before - 32 kHz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a blank like after the (sub)list ends and before - RTC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a blank line before this sublist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and a blank line after the sublist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add blank line before and after the sublist... same for the sublists below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent needs to match previous line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sublists should have a blank like before and after htem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few formatting tweaks, otherwise looks OK
237dc4f
to
3f293d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
dts/arm/nucleo_l432kc.fixup
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename ST_STM32_USART_40013800_BAUD_RATE as ST_STM32_USART_40013800_CURRENT_SPEED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
dts/arm/nucleo_l432kc.fixup
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
dts/arm/nucleo_l432kc.fixup
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
dts/arm/nucleo_l432kc.fixup
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry previous comment. I only ment to +1 only first commit.
Removing the "approved on all changes"
3f293d2
to
38d12c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SoC and Board bits should be split, so that the board.dts, dts/arm/Makefile, fixup, are part of the patch that adds the board to Zephyr.
ef77407
to
2dfc637
Compare
@galak it seems the shippable script throws me errors on commits not part of this PR |
2dfc637
to
abc039f
Compare
78c0221
to
a1c74b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the patch sequence seems out of order here:
The board patch should be last. I'd expect:
- pinmux: stm32: Do not compile PORTD when not available
- arm: stm32l4: Add configuration for STM32L432XX
(merge dts: Add support for STM32L432) - pinmux: stm32: Add support for Nucleo L432KC
- boards: arm: Add Nucleo L432KC (merge dts: Add support for Nucleo L432KC)
The STM32L432 does not have a PORTD gpio, disable it when not available. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
abc039f
to
961ada0
Compare
Add configuration and dts for the STM32L432XX SoC STM32L4 variant. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Add pinmux configuration for the Nucleo L432KC board Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
961ada0
to
1f9bafd
Compare
Hmm, when pushing partial rebase, the order showed in the PR is wrong.. On the original branch (https://github.com/superna9999/zephyr/commits/stm32l432_nucleo) , the commits are: But the shippable status is on the good commit. |
Add configuration, dts and documentation for the Nucleo L432KC board based on the STM32L432KC SoC. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
1f9bafd
to
5675509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good - let me see about dbkinder adding his approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess just leaving a +1 comment doesn't work, so I'll pick the Approve button this time 👍
…m-dev-17.05 Master upstream dev 17.05
feat: ci: add gitlint and stylecheck Closes zephyrproject-rtos#19, zephyrproject-rtos#22, and zephyrproject-rtos#23 See merge request blik/embedded/zephyr!26
Certain Qualcomm controllers do not accept our settings for Host Buffer Size: < HCI Command: Host Buffer Size (0x03|0x0033) plen 7 zephyrproject-rtos#19 [hci0] 22.391048 ACL MTU: 27 ACL max packet: 6 SCO MTU: 0 SCO max packet: 0 > HCI Event: Command Complete (0x0e) plen 4 zephyrproject-rtos#20 [hci0] 22.391525 Host Buffer Size (0x03|0x0033) ncmd 1 Status: Invalid HCI Command Parameters (0x12) Likely due to the fact that we do not reserve space for any SCO packets in the Host. Other Controllers (Realtek) seem to not transmit any data at all in the Controller to Host direction if Controller to Host flow control is enabled. Document this fact in the User Guide so that users know what to do when this happens. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Certain Qualcomm controllers do not accept our settings for Host Buffer Size: < HCI Command: Host Buffer Size (0x03|0x0033) plen 7 #19 [hci0] 22.391048 ACL MTU: 27 ACL max packet: 6 SCO MTU: 0 SCO max packet: 0 > HCI Event: Command Complete (0x0e) plen 4 #20 [hci0] 22.391525 Host Buffer Size (0x03|0x0033) ncmd 1 Status: Invalid HCI Command Parameters (0x12) Likely due to the fact that we do not reserve space for any SCO packets in the Host. Other Controllers (Realtek) seem to not transmit any data at all in the Controller to Host direction if Controller to Host flow control is enabled. Document this fact in the User Guide so that users know what to do when this happens. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Certain Qualcomm controllers do not accept our settings for Host Buffer Size: < HCI Command: Host Buffer Size (0x03|0x0033) plen 7 #19 [hci0] 22.391048 ACL MTU: 27 ACL max packet: 6 SCO MTU: 0 SCO max packet: 0 > HCI Event: Command Complete (0x0e) plen 4 #20 [hci0] 22.391525 Host Buffer Size (0x03|0x0033) ncmd 1 Status: Invalid HCI Command Parameters (0x12) Likely due to the fact that we do not reserve space for any SCO packets in the Host. Other Controllers (Realtek) seem to not transmit any data at all in the Controller to Host direction if Controller to Host flow control is enabled. Document this fact in the User Guide so that users know what to do when this happens. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
…zephyrproject-rtos#19) linker: Updated Linker script with linker script fragments Modified linker script to use linker script fragments and added MACROs for section definitions Signed-off-by: Adhil Xavier <adhil.xavier@ignitarium.com>
The STM32L4x2 SoC serie is a lowered down version of the STM32L4x6 SoCs.
This PR adds support for the STM32L432KC SoC and support for the Nucleo L432KC from the Nucleo-32 boards serie.
Documentation for the Nucleo L432KC is added based on the Nucleo L476RG format.
This change is