Skip to content

Conversation

superna9999
Copy link
Contributor

@superna9999 superna9999 commented Apr 29, 2017

The STM32L4x2 SoC serie is a lowered down version of the STM32L4x6 SoCs.

This PR adds support for the STM32L432KC SoC and support for the Nucleo L432KC from the Nucleo-32 boards serie.
Documentation for the Nucleo L432KC is added based on the Nucleo L476RG format.


This change is Reviewable

@nashif nashif requested a review from dbkinder April 29, 2017 20:46
@galak galak self-assigned this Apr 29, 2017
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists (and sub-lists) need a blank line before and after the lists, so add a blank line before - 32 kHz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a blank like after the (sub)list ends and before - RTC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a blank line before this sublist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and a blank line after the sublist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add blank line before and after the sublist... same for the sublists below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent needs to match previous line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sublists should have a blank like before and after htem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few formatting tweaks, otherwise looks OK

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename ST_STM32_USART_40013800_BAUD_RATE as ST_STM32_USART_40013800_CURRENT_SPEED

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry previous comment. I only ment to +1 only first commit.
Removing the "approved on all changes"

Copy link
Contributor

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SoC and Board bits should be split, so that the board.dts, dts/arm/Makefile, fixup, are part of the patch that adds the board to Zephyr.

@superna9999 superna9999 force-pushed the stm32l432_nucleo branch 2 times, most recently from ef77407 to 2dfc637 Compare May 3, 2017 07:51
@superna9999
Copy link
Contributor Author

@galak it seems the shippable script throws me errors on commits not part of this PR

@pfalcon pfalcon mentioned this pull request May 3, 2017
@galak galak force-pushed the arm branch 2 times, most recently from 78c0221 to a1c74b7 Compare May 4, 2017 14:02
Copy link
Contributor

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the patch sequence seems out of order here:
The board patch should be last. I'd expect:

  1. pinmux: stm32: Do not compile PORTD when not available
  2. arm: stm32l4: Add configuration for STM32L432XX
    (merge dts: Add support for STM32L432)
  3. pinmux: stm32: Add support for Nucleo L432KC
  4. boards: arm: Add Nucleo L432KC (merge dts: Add support for Nucleo L432KC)

The STM32L432 does not have a PORTD gpio, disable it when not available.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Add configuration and dts for the STM32L432XX SoC STM32L4 variant.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Add pinmux configuration for the Nucleo L432KC board

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
@superna9999
Copy link
Contributor Author

Hmm, when pushing partial rebase, the order showed in the PR is wrong..

On the original branch (https://github.com/superna9999/zephyr/commits/stm32l432_nucleo) , the commits are:
1f9bafd boards: arm: Add support for Nucleo L432KC
b0de4a3 pinmux: stm32: Add support for Nucleo L432KC
7f2fff1 arm: stm32l4: Add configuration and dts for STM32L432XX
3106ca4 pinmux: stm32: Do not compile PORTD when not available

But the shippable status is on the good commit.

Add configuration, dts and documentation for the Nucleo L432KC board
based on the STM32L432KC SoC.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Copy link
Contributor

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good - let me see about dbkinder adding his approval

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess just leaving a +1 comment doesn't work, so I'll pick the Approve button this time 👍

@galak galak merged commit 2187c1c into zephyrproject-rtos:arm May 8, 2017
mike-scott pushed a commit to mike-scott/zephyr that referenced this pull request May 30, 2017
frasa pushed a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019
feat: ci: add gitlint and stylecheck

Closes zephyrproject-rtos#19, zephyrproject-rtos#22, and zephyrproject-rtos#23

See merge request blik/embedded/zephyr!26
carlescufi added a commit to carlescufi/zephyr that referenced this pull request Apr 30, 2020
Certain Qualcomm controllers do not accept our settings for Host Buffer
Size:

< HCI Command: Host Buffer Size (0x03|0x0033) plen 7       zephyrproject-rtos#19 [hci0]
22.391048
        ACL MTU: 27   ACL max packet: 6
        SCO MTU: 0    SCO max packet: 0
> HCI Event: Command Complete (0x0e) plen 4                zephyrproject-rtos#20 [hci0]
22.391525
      Host Buffer Size (0x03|0x0033) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

Likely due to the fact that we do not reserve space for any SCO packets
in the Host.

Other Controllers (Realtek) seem to not transmit any data at all in the
Controller to Host direction if Controller to Host flow control is
enabled.

Document this fact in the User Guide so that users know what to do when
this happens.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
jhedberg pushed a commit that referenced this pull request Apr 30, 2020
Certain Qualcomm controllers do not accept our settings for Host Buffer
Size:

< HCI Command: Host Buffer Size (0x03|0x0033) plen 7       #19 [hci0]
22.391048
        ACL MTU: 27   ACL max packet: 6
        SCO MTU: 0    SCO max packet: 0
> HCI Event: Command Complete (0x0e) plen 4                #20 [hci0]
22.391525
      Host Buffer Size (0x03|0x0033) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

Likely due to the fact that we do not reserve space for any SCO packets
in the Host.

Other Controllers (Realtek) seem to not transmit any data at all in the
Controller to Host direction if Controller to Host flow control is
enabled.

Document this fact in the User Guide so that users know what to do when
this happens.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
hakehuang referenced this pull request in hakehuang/zephyr Jun 20, 2020
Certain Qualcomm controllers do not accept our settings for Host Buffer
Size:

< HCI Command: Host Buffer Size (0x03|0x0033) plen 7       #19 [hci0]
22.391048
        ACL MTU: 27   ACL max packet: 6
        SCO MTU: 0    SCO max packet: 0
> HCI Event: Command Complete (0x0e) plen 4                #20 [hci0]
22.391525
      Host Buffer Size (0x03|0x0033) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

Likely due to the fact that we do not reserve space for any SCO packets
in the Host.

Other Controllers (Realtek) seem to not transmit any data at all in the
Controller to Host direction if Controller to Host flow control is
enabled.

Document this fact in the User Guide so that users know what to do when
this happens.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
MuhammedZamroodh pushed a commit to Zephyr4Microchip/zephyr that referenced this pull request Aug 5, 2025
…zephyrproject-rtos#19)

linker: Updated Linker script with linker script fragments

Modified linker script to use linker script fragments and added MACROs
for section definitions

Signed-off-by: Adhil Xavier <adhil.xavier@ignitarium.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants