Skip to content

[Backport v1.14-branch] Bluetooth: GATT: Fix assuming writes to CCC will always contain 2 bytes #16740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nashif merged 1 commit into from
Jun 11, 2019
Merged

[Backport v1.14-branch] Bluetooth: GATT: Fix assuming writes to CCC will always contain 2 bytes #16740

nashif merged 1 commit into from
Jun 11, 2019

Conversation

@backporting
Copy link

@backporting backporting bot commented Jun 11, 2019 •
edited by nashif
Loading

Backport #16731.

Fixes #16734

@Vudentz
Bluetooth: GATT: Fix assuming writes to CCC will always contain 2 bytes
1c2e1f5 
Although unlikely it is possible that a remote may attempt to send just
1 byte as the write request allows to do that:

BLUETOOTH CORE SPECIFICATION Version 5.1 | Vol 3, Part F
page 2320:

  'If the attribute value has a fixed length and the Attribute Value
  parameter length is less than or equal to the length of the attribute
  value, the octets of the attribute value parameter length shall be
  written; all other octets in this attribute value shall be
  unchanged.'

Fixes #16734

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
@backporting backporting bot requested review from Vudentz, jhedberg and sjanc as code owners June 11, 2019 12:47
@zephyrbot
Copy link

zephyrbot commented Jun 11, 2019

Found the following issues, please fix and resubmit:

Kconfig issues


Found references to undefined Kconfig symbols. If any of these are false
positives, then add them to UNDEF_KCONFIG_WHITELIST in check_compliance.py in the ci-tools repo.

If the reference is for a comment like /* CONFIG_FOO_* */ (or
/* CONFIG_FOO_*_... */), then please use exactly that form (with the '*'). The
CI check knows not to flag it.

More generally, a reference followed by $, @, {, *, or ## will never be
flagged.

CONFIG_CLOCK_STM32_PLL_SRC_                drivers/clock_control/stm32_ll_clock.c:313
CONFIG_SOC_SERIES_                         drivers/gpio/gpio_stm32.h:105

@nashif nashif merged commit 6950a38 into v1.14-branch Jun 11, 2019
@nashif nashif deleted the backport-16731-to-v1.14-branch branch June 11, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nashif nashif nashif approved these changes

@jhedberg jhedberg jhedberg approved these changes

@sjanc sjanc Awaiting requested review from sjanc sjanc is a code owner

@Vudentz Vudentz Awaiting requested review from Vudentz

Assignees

No one assigned

Labels

area: Bluetooth

Projects

Backports
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zephyrbot @nashif @jhedberg @Vudentz