Bluetooth: controller: split: Port Enc setup to be queueable #16499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
added
area: Bluetooth
bug
cvinayak
force-pushed
the
github_port_enc_queueable
branch
from
5440e8a to
bd1e8fb
Compare
joerchan
approved these changes
Jun 4, 2019
Contributor
joerchan
left a comment
joerchan
left a comment
There was a problem hiding this comment.
looks good, left a few small comments.
Contributor
Author
There was a problem hiding this comment.
The state is maintained as a differential value:
0. Request lock is idle
- Thread acquires a lock on the request, if req == ack then req +=1;
- Thread commits the request, req +=1 or (req-ack) == 2
If ISR occurs between the thread checking for req == ack and req +=1, then in the thead the differential will be (req-ack) == 3, indicating a race condition. In this case, thread will back-off by reverting req -= 1, resulting in a final (req-ack) == 2 (i.e. ISR request supercedes).
On the contrary, if ISR detects that request is acquired it backs-off to retry later.
Contributor
There was a problem hiding this comment.
move this pause_tx into llcp_enc?
Contributor
Author
There was a problem hiding this comment.
agreed. Will give a try.
Port the fix for the controller implementation to make start encryption queueable if there is any control procedure in progress. Refer to zephyrproject-rtos#15335. Relates to zephyrproject-rtos#15335, zephyrproject-rtos#15186, zephyrproject-rtos#15958 and zephyrproject-rtos#14636. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
force-pushed
the
github_port_enc_queueable
branch
from
bd1e8fb to
24c72ab
Compare
carlescufi
approved these changes
Jun 5, 2019
Contributor
Author
|
We wait for review from @thoh-ot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the fix for the controller implementation to make start
encryption queueable if there is any control procedure in
progress.
Refer to #15335.
Relates to #15335, #15186, #15958 and #14636.
Signed-off-by: Vinayak Kariappa Chettimada vich@nordicsemi.no