-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Added support to access native posix flash via host file system #16467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to access native posix flash via host file system #16467
Conversation
|
All checks are passing now. Review history of this comment for details about previous failed status. |
fc7af16 to
2b2341a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the code, kconfig and cmake into drivers/flash
The Kconfig can be into drivers/flash/Kconfig.native_posix
The cmake chunk into drivers/flash/CMakeLists.txt
The code could be just named drivers/flash/fuse_native_posix.c or so
I did try this but it is not an option as the compiler flags need to be changed to make use of FUSE and there is a conflict with the flags used in the zephyr flash library. |
dbkinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the documentation. I've got a few recommended edits.
@vanwinkeljan Would declaring the fuse part as a separate library do the trick? (even if it is in the same folder as the other flash drivers) |
2b2341a to
37192c7
Compare
Yes it does, moved the code to subsys/fs |
|
Renamed fuse_flash to fuse_fs_access as the code actually only provides access to the FS partitions |
|
@vanwinkeljan I guess you have tested that it works nicely? |
|
@vanwinkeljan Apart from those minor issues I'm ok with this, and can approve it after you fixed them |
dbkinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one fix to remove the doc-build warning...
37192c7 to
1349de5
Compare
Done
No problem with that, I think it is an added value for zephyr |
|
The Makefile in the Zephyr root has this htmldocs-fast target. |
|
Any chance that this will work on widowns? |
No currently this not possible due to 2 limitations:
Now it looks that both issues will be solved by introduction of WSL2, an initial build of WSL2 would be available by end of June for people with access to WIndows Insider. |
Added API the read mount point names Signed-off-by: Jan Van Winkel <jan.van_winkel@dxplore.eu>
Added support to access flash device partitions from host through FUSE. Signed-off-by: Jan Van Winkel <jan.van_winkel@dxplore.eu>
Added file system shell sample Signed-off-by: Jan Van Winkel <jan.van_winkel@dxplore.eu>
1349de5 to
29fb346
Compare
dbkinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs LGTM, thanks!
Add support to access native posix flash device via host file system.
The flash device is mapped into the host file system by means of the FUSE library.
These changesets where original part of PR #12503
edit: actually only access to FS partitions is provided