tests: ringbuffer: avoid unaligned mem access #15311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casting the rb_data character array to a u32_t can result in an unaligned u32_t * pointer being passed to ring_buf_item_put(), since rb_data is only byte-aligned. Our Altera Max10 CPU build is not configured to detect unaligned memory access and throw an exception, it is instead rounding down the memory address of the data pointer to the nearest 4-byte value, causing the wrong data to be copied into the ring buffer. It appears that in the C standard this is considered Undefined Behavior so the approach this patch takes is to fix the test, by ensuring that rb_data is aligned to u32_t. Fixes: zephyrproject-rtos#14869 Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
dcpleung
approved these changes
Apr 9, 2019
ghost
approved these changes
Apr 9, 2019
nashif
approved these changes
Apr 9, 2019
Contributor
|
verified that the tests/lib/ringbuffer test cases are passed with the latest commit 9926f94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting the rb_data character array to a u32_t can result
in an unaligned u32_t * pointer being passed to
ring_buf_item_put(), since rb_data is only byte-aligned.
Our Altera Max10 CPU build is not configured to detect
unaligned memory access and throw an exception, it is
instead rounding down the memory address
of the data pointer to the nearest 4-byte value, causing
the wrong data to be copied into the ring buffer.
It appears that in the C standard this is considered
Undefined Behavior so the approach this patch takes is
to fix the test, by ensuring that rb_data is aligned to
u32_t.
Fixes: #14869
Signed-off-by: Andrew Boie andrew.p.boie@intel.com