net: dns: Do not resolve IPv6 address if IPv6 is disabled #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
In progress
andyross
previously approved these changes
Sep 13, 2017
If IPv6 is disabled, then it is useless to try to resolve IPv6 address because "struct sockaddr" does not have enough space to store IPv6 address. Fixes zephyrproject-rtos#1487 Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Member
Author
|
Sent a new version as I forgot to add a new conf file to the PR. I should probably avoid fixing bugs too late in the evening. |
Member
|
This should get to 1.9.1. |
Member
Author
I would like to see this merged in master first. How are we handling the 1.9.1 patches, is Anas picking this patch to 1.9.1? |
pfalcon
approved these changes
Sep 18, 2017
Contributor
Hmm, I don't think this patch fixes a too serious issue, more like a niche one. (I'm actually surprised (and appreciate) that @jukkar went to fix it so quickly.) |
ghost
removed
the
In progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If IPv6 is disabled, then it is useless to try to resolve
IPv6 address because "struct sockaddr" does not have enough
space to store IPv6 address.
Fixes #1487
Signed-off-by: Jukka Rissanen jukka.rissanen@linux.intel.com