Kconfig: Remove blank lines at the beginning/end of files #14452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulfalizer
requested review from
MaureenHelm,
aescolar,
andrewboie,
avisconti,
galak,
nashif,
ramakrishnapallala,
ruuddw and
vanwinkeljan
as code owners
ulfalizer
force-pushed
the
kconfig-blank-lines
branch
3 times, most recently
from
2e71e10 to
4e3ebbf
Compare
ulfalizer
added
area: Kconfig
Trivial
aescolar
approved these changes
Mar 13, 2019
Member
aescolar
left a comment
aescolar
left a comment
There was a problem hiding this comment.
In my case it wasn't a "just in case" but a "just copy paste and replace" :)
vanwinkeljan
approved these changes
Mar 13, 2019
ulfalizer
force-pushed
the
kconfig-blank-lines
branch
from
4e3ebbf to
a88d01e
Compare
ulfalizer
requested review from
Vudentz,
anangl,
andyross,
dcpleung,
erwango,
ioannisg,
jakub-uC,
jhedberg,
nordic-krch,
rgundi,
sjanc and
tbursztyka
as code owners
ulfalizer
changed the title
Contributor
Author
|
Checked the ends now too. Intense nitting. |
ioannisg
approved these changes
Mar 13, 2019
nordic-krch
approved these changes
Mar 13, 2019
anangl
approved these changes
Mar 13, 2019
jhedberg
approved these changes
Mar 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #14452 +/- ##
==========================================
+ Coverage 51.98% 52.12% +0.13%
==========================================
Files 308 308
Lines 45505 45523 +18
Branches 10543 10552 +9
==========================================
+ Hits 23655 23728 +73
+ Misses 17050 16990 -60
- Partials 4800 4805 +5
Continue to review full report at Codecov.
|
ulfalizer
force-pushed
the
kconfig-blank-lines
branch
from
a88d01e to
af6245d
Compare
Maybe this is some "just in case" thing that got copied around. There's no need to have a blank line at the beginning or end of Kconfig files. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
ulfalizer
force-pushed
the
kconfig-blank-lines
branch
from
af6245d to
9675040
Compare
ulfalizer
added a commit
to ulfalizer/zephyr
that referenced
this pull request
Mar 18, 2019
This one got away in zephyrproject-rtos#14452. Didn't spot there were two blank lines. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
galak
pushed a commit
that referenced
this pull request
Mar 26, 2019
This one got away in #14452. Didn't spot there were two blank lines. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this is some "just in case" thing that got copied around. There's
no need to have a blank line at the beginning or end of Kconfig files.