doc: Documentation issue in 'boards/shields/arduino_giga_display_shield/doc/index'

[dleach02]

Describe the bug

The instructions to build do not work.

west build -b arduino_giga_r1_wifi --shield arduino_giga_display_shield samples/subsys/display/lvgl

• there is no board target for arduino_giga_r1_wifi.
• if you correct the board name to arduino_giga_r1/stm32h747xx/m7 it errors on the shield name.
• if you set the shield name to giga_display_shield, you get a build error

west build -p -b arduino_giga_r1/stm32h747xx/m7 --shield giga_display_shield samples/subsys/display/lvgl

Results with:

C:/work/zephyrproject/zephyr/drivers/display/display_stm32_ltdc.c: In function 'stm32_ltdc_init':
C:/work/zephyrproject/zephyr/drivers/display/display_stm32_ltdc.c:422:25: error: 'CONFIG_VIDEO_BUFFER_SMH_ATTRIBUTE' undeclared (first use in this function)
  422 |                         CONFIG_VIDEO_BUFFER_SMH_ATTRIBUTE,
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:/work/zephyrproject/zephyr/drivers/display/display_stm32_ltdc.c:422:25: note: each undeclared identifier is reported only once for each function it appears in
[136/468] Building C object modules/lvgl/CMakeFiles/module...phyrproject/modules/lib/gui/lvgl/src/core/lv_obj_pos.c.obj
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: 'C:\Strawberry\c\bin\cmake.EXE' --build 'C:\work\zephyrproject\zephyr\build'

C

Environment

• Page: boards/shields/arduino_giga_display_shield/doc/index
• Version: main
• SHA-1: 9cea552

[dleach02]

@iabdalkader ping

[iabdalkader]

Does this fix the issue? #89246

[moosery]

I manually applied those changes in #89246 and while it now compiles, the arduino giga display isn't showing anything. Also, the doc still needs to be updated to the right board name / shield name per @dleach02's comments.

Unfortunately I am too new to using zephyr and I don't know which port the error logs are being written to. Once I figure that out I can provide more insight.

[iabdalkader]

and while it now compiles, the arduino giga display isn't showing anything.

Does any other sample work? Like samples/drivers/display/ or maybe samples/subsys/display/cfb?

[moosery]

Same thing, compiles but the display isn't showing anything for either of those samples.

[iabdalkader]

So normally we use this from the Arduino Zephyr core, which does other initialization. One thing that jumps to mind is SMH init. Can you try adding the following to your main.c?

#if defined(CONFIG_SHARED_MULTI_HEAP)
#include <zephyr/kernel.h>
#include <zephyr/devicetree.h>
#include <zephyr/multi_heap/shared_multi_heap.h>

struct memory_region_t {
	uintptr_t dt_addr;
	size_t dt_size;
	const char *dt_name;
};

#define _BUILD_MEM_REGION(node_id)      \
	{ .dt_addr = DT_REG_ADDR(node_id),  \
      .dt_size = DT_REG_SIZE(node_id),  \
      .dt_name = DT_PROP(node_id, zephyr_memory_region) \
    },

int smh_init(void)
{
    int ret = 0;
    ret = shared_multi_heap_pool_init();
    if (ret != 0) {
        return ret;
    }

    const struct memory_region_t regions[] = {
        DT_FOREACH_STATUS_OKAY(zephyr_memory_region, _BUILD_MEM_REGION)
    };

    for (size_t i=0; i<ARRAY_SIZE(regions); i++) {
        if (!strncmp("SDRAM", regions[i].dt_name, 5)) {
            struct shared_multi_heap_region smh_sdram = {
                .addr = regions[i].dt_addr,
                .size = regions[i].dt_size,
                .attr = SMH_REG_ATTR_EXTERNAL,
            };
            ret = shared_multi_heap_add(&smh_sdram, NULL);
            if (ret != 0) {
                return ret;
            }
        }
    }
	return 0;
}

SYS_INIT(smh_init, POST_KERNEL, CONFIG_KERNEL_INIT_PRIORITY_DEFAULT);
#endif

[moosery]

I added your code to the samples/drivers/display and it compiles but fails to link.

c:/users/moosery/zephyr-sdk-0.17.0/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd.exe: Undefined initialization levels used.
collect2.exe: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: 'C:\Program Files\CMake\bin\cmake.EXE' --build 'C:\zephyr\gigazephyr\zephyr\build'

[iabdalkader]

Yes, it's probably the copy&paste init priority. Try CONFIG_KERNEL_INIT_PRIORITY_DEFAULT.

[moosery]

That works! I get the white screen with a red block in upper left, green block in upper right, blue block in lower left and lower right block is cycling colors!

[moosery]

FYI - Also put that in the main.c for the samples/subsys/display/lvgl - got the hello world text and the counter at the bottom (display in portrait mode).