Skip to content

usb: protocol field in descriptor for CDC ACM should default to zero #6646

@IvanSanchez

Description

@IvanSanchez

The protocol field here at

.bInterfaceProtocol = V25TER_PROTOCOL,

should default to 0x00 (meaning "no protocol") instead of 0x01 (meaning "I'm actively advertising that I support the AT V.250 protocol" AKA V25TER).

Although this field has been ignored by major OSs during the last decades, this creates a big deal of problems with ModemManager sending unexpected AT commands when plugging in a dev board. This has been mitigated up to some point by having ID_MM_DEVICE_IGNORE udev rules all over the place, which is just a stopgap measure.

This is a simple change, but I don't want to send a pull request before more work in #4661 is done due to fear of merge conflicts. Also, some applications might want to advertise support for some AT command set or ethernet emulation or a vendor protocol (see table here), which is related to #4661 (refactor usb descriptors) and #6593 (let developers specify some values when putting together the usb descriptors).

cc @finikorg @jfischer-phytec-iot

Metadata

Metadata

Assignees

Labels

area: USBUniversal Serial BusbugThe issue is a bug, or the PR is fixing a bugpriority: mediumMedium impact/importance bug

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions