Skip to content

[Coverity CID :216783] Side effect in assertion in tests/lib/p4workq/src/main.c #31670

@zephyrbot

Description

@zephyrbot

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/f91e9fba51e5da46ee5c6822f8656713d74a6ecf/tests/lib/p4workq/src/main.c#L237

Category: Incorrect expression
Function: test_resubmit
Component: Tests
CID: 216783

Details:

231         run_count = 0;
232         simple_item = (struct k_p4wq_work){};
233         simple_item.handler = resubmit_handler;
234         k_p4wq_submit(&wq, &simple_item);
235    
236         k_msleep(100);
>>>     CID 216783:  Incorrect expression  (ASSERT_SIDE_EFFECT)
>>>     Argument "run_count" of z_zassert() has a side effect because the variable is volatile.  The containing function might work differently in a non-debug build.
237         zassert_equal(run_count, 2, "Wrong run count: %d\n", run_count);
238     }
239    
240     void simple_handler(struct k_p4wq_work *work)
241     {
242         zassert_equal(work, &simple_item, "bad work item pointer");

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

Metadata

Metadata

Assignees

Labels

CoverityA Coverity detected issue or its fixbugThe issue is a bug, or the PR is fixing a bugpriority: lowLow impact/importance bug

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions