Checkpatch compliance errors do not fail CI

[cvinayak]

Describe the bug
Checkpatch.pl compliance errors in commit description style are not flagged in PR CI builds.

To Reproduce
Steps to reproduce the behavior:

1. Submit a PR with commit description style error, example in 013cacf

Expected behavior
CI compliance check shall fail the PR, and restrict merging of the commits upstream.

Impact
showstopper.

Logs and console output
Local failure:

Environment (please complete the following information):

• OS: Linux
• Toolchain: Zephyr SDK
• Commit SHA or Version used: 89f6e24

Additional context
NA

[carlescufi]

Please consider that checkpatch is invoked on a diff, not on a commit in CI:
https://github.com/zephyrproject-rtos/zephyr/blob/master/scripts/ci/check_compliance.py#L205

[nashif]

do not see the issue here, can you show that this error occurs in CI? What happens locally in your tree is not the same thing in CI, hence the local error.

[cvinayak]

@nashif Take a look at the commit body of 013cacf, its missing the title for the referenced commit hash, is it acceptable to be merged to master?

[cvinayak]

Please consider that checkpatch is invoked on a diff, not on a commit in CI:
https://github.com/zephyrproject-rtos/zephyr/blob/master/scripts/ci/check_compliance.py#L205

./scripts/checkpatch.pl -g HEAD...upstream/master this how I run when I have multiple commits, so that commit message too is checked for compliance.

I think lately typo's and commit description style are not flagged by CI anymore.

[nashif]

I think lately typo's and commit description style are not flagged by CI anymore.

commit messages in CI are not checked by checkpatch, we have gitlint for this.

[cvinayak]

ok, so gitlint does not check typo and commit description style? Is this deliberate choice to be not included in PR CI?

Example of typo thats not flagged in PR CI: https://github.com/zephyrproject-rtos/zephyr/pull/29987/files#diff-8e1f696f9ab3c0c376eb7260774364f18de97f3205739af8bffc52cac22455c3R18

[cvinayak]

Another example, mispelled "instread" here: d8e088d

[nashif]

gitlint does not check for typos, those are part of the code, not the commit message.

[nashif]

checkpatch has spelling check, but that is only a warning and is not flagged by CI.

[jfischer-no]

I reopen this bug report.
The initial description is correct. Checkpatch in CI does not work properly and does not report style issues. I could reproduce it reviewing #30299. PR checked out, git diff HEAD~1 | checkpatch.pl --mailback --no-tree - just as checkpatch.pl -g HEAD or checkpatch.pl -g 1cb4ac697d8fe4160f42e82a202f5cbd5b1d01f7 report style issues, but CI does not.