net: 9cd547f53b "Fix ref counting for the net_pkt" allegedly broke reference counting

[pfalcon]

Culprit, based on dissecting: 9cd547f

Steps to reproduce: samples/net/sockets/dumb_http_server BOARD=qemu_x86 OVERLAY=overlay-e1000.conf (which got added only in 9468365), then as usual run ab -n1000 http://192.0.2.1:8080/.

Seen behavior (100% and exactly reproducible):

Benchmarking 192.0.2.1 (be patient)
apr_pollset_poll: The timeout specified has expired (70007)
Total of 14 requests completed

Expected behavior: 1000 requests should go thru.

[pfalcon]

This would be "Priority: High". But as I'm not a release manager, I don't set it.

[pfalcon]

Also reproducible with default set up of dumb_http_server (i.e. qemu_x86 + SLIP).

$ ab -n1000 http://192.0.2.1:8080/
This is ApacheBench, Version 2.3 <$Revision: 1807734 $>
Copyright 1996 Adam Twiss, Zeus Technology Ltd, http://www.zeustech.net/
Licensed to The Apache Software Foundation, http://www.apache.org/

Benchmarking 192.0.2.1 (be patient)
apr_pollset_poll: The timeout specified has expired (70007)
Total of 14 requests completed

SeaBIOS (version rel-1.12.0-0-ga698c8995f-prebuilt.qemu.org)
Booting from ROM..***** Booting Zephyr OS v1.14.0-rc1-1430-g9cd547f53b74 *****
[00:00:00.150,000] <inf> net_config: Initializing network
[00:00:00.150,000] <inf> net_config: IPv4 address: 192.0.2.1
Single-threaded dumb HTTP server waits for a connection on port 8080...
Connection #0 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #1 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #2 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #3 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #4 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #5 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #6 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #7 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #8 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #9 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #10 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #11 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #12 from 192.0.2.2
Connection from 192.0.2.2 closed
Connection #13 from 192.0.2.2
Error sending data to peer
Connection from 192.0.2.2 closed

[pfalcon]

Also reproducible with BOARD=mps2_an385 CONF_FILE="prj.conf overlay-smsc911x.conf".

[jukkar]

Hmm, I will investigate this. The original commit I sent fixed a real issue. It seems that the fix exposed some other issue.