-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Closed
Closed
Copy link
Labels
area: NetworkingbugThe issue is a bug, or the PR is fixing a bugThe issue is a bug, or the PR is fixing a bugpriority: mediumMedium impact/importance bugMedium impact/importance bug
Milestone
Description
48abdc2, which was part of #12855, removed echo_server (non-socket version) sample app, which was the "default" sample for networking smoke-testing. As such, it included many config overlays test configs (in sample.yaml) to cover various option combinations and drivers. All of them were lost.
Example of lost test configs are those added in commits 7117b73 and e779f91 - and those only the configs added literally 10 days before they were blind-removed like that, there're probably more useful configs added over last 2 years.
Bottom line:
- There were shared concerns that net_app removal from 1.14 is a hasty move.
- Instead of blind-removing (
rm -rf *-style) everything like that, test config should have been ported over the other sample(s). (With RFC regarding what becomes a new default "smoke test app"). - Not done at right time, it needs to be done now.
Metadata
Metadata
Assignees
Labels
area: NetworkingbugThe issue is a bug, or the PR is fixing a bugThe issue is a bug, or the PR is fixing a bugpriority: mediumMedium impact/importance bugMedium impact/importance bug