Skip to content

Commit

Permalink
intel_adsp: ace: do not use external kconfigs in code
Browse files Browse the repository at this point in the history
use CONFIG_SOC_INTEL_ACE15_MTPM instead of CONFIG_ACE_VERSION_1_5.

CONFIG_ACE_VERSION_1_5 leaked from SOF.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
  • Loading branch information
nashif committed Jan 22, 2024
1 parent e4b761a commit 6df6935
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions drivers/power_domain/power_domain_intel_adsp.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
#include <zephyr/pm/device_runtime.h>
#include <adsp_shim.h>

#if CONFIG_ACE_VERSION_1_5
#if CONFIG_SOC_INTEL_ACE15_MTPM
#include <adsp_power.h>
#endif /* CONFIG_ACE_VERSION_1_5 */
#endif /* CONFIG_SOC_INTEL_ACE15_MTPM */

#include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(power_domain_intel_adsp, LOG_LEVEL_INF);
Expand All @@ -35,7 +35,7 @@ static int pd_intel_adsp_set_power_enable(struct pg_bits *bits, bool power_enabl
return -EIO;
}
} else {
#if CONFIG_ACE_VERSION_1_5
#if CONFIG_SOC_INTEL_ACE15_MTPM
extern uint32_t g_key_read_holder;

if (bits->SPA_bit == INTEL_ADSP_HST_DOMAIN_BIT) {
Expand Down
8 changes: 4 additions & 4 deletions soc/xtensa/intel_adsp/ace/multiprocessing.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@

#define ACE_INTC_IRQ DT_IRQN(DT_NODELABEL(ace_intc))

#if CONFIG_ACE_VERSION_1_5
#if CONFIG_SOC_INTEL_ACE15_MTPM
/* .bss is uncached, we further check it below */
uint32_t g_key_read_holder;
#endif /* CONFIG_ACE_VERSION_1_5 */
#endif /* CONFIG_SOC_INTEL_ACE15_MTPM */

static void ipc_isr(void *arg)
{
Expand Down Expand Up @@ -88,11 +88,11 @@ void soc_mp_init(void)

/* Set the core 0 active */
soc_cpus_active[0] = true;
#if CONFIG_ACE_VERSION_1_5
#if CONFIG_SOC_INTEL_ACE15_MTPM
__ASSERT(!arch_xtensa_is_ptr_cached(&g_key_read_holder),
"g_key_read_holder must be uncached");
g_key_read_holder = INTEL_ADSP_ACE15_MAGIC_KEY;
#endif /* CONFIG_ACE_VERSION_1_5 */
#endif /* CONFIG_SOC_INTEL_ACE15_MTPM */
}

static int host_runtime_get(void)
Expand Down

0 comments on commit 6df6935

Please sign in to comment.