Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/commands: Remove unused nonlocal/global declarations #798

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

pdgendt
Copy link
Collaborator

@pdgendt pdgendt commented Mar 31, 2025

Some variables were declared with either nonlocal or global but never assigned any value in their scope.

Fixes #797

pdgendt added 3 commits March 31, 2025 12:01
Make the list of additionally selected rules sorted.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Some variables were declared as nonlocal but never assigned in the
scope.
Fixes pyflakes F824 warnings.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Some variables were declared with the global keyword, but never assigned
a new value in that scope.
Fixes pyflakes F824 warning.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
@pdgendt pdgendt added this to the v1.4.0 milestone Mar 31, 2025
@pdgendt pdgendt added the bug Something isn't working label Apr 1, 2025
@carlescufi carlescufi merged commit 76fd691 into zephyrproject-rtos:main Apr 2, 2025
22 checks passed
@pdgendt pdgendt deleted the flake8-ci branch April 2, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox fails on flake8 rule F824
3 participants