Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch even SHA revisions directly #475

Closed
wants to merge 2 commits into from
Closed

Fetch even SHA revisions directly #475

wants to merge 2 commits into from

Commits on Feb 8, 2021

  1. west update: delete dead code in helper 

    Nobody is calling _fetch() with a rev kwarg; delete this stale code.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
    @mbolivar-nordic
    mbolivar-nordic committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    e7b40d2 View commit details
    Browse the repository at this point in the history

  2. west update: fetch SHAs directly 

    Since we implemented the feature, GitHub has started to allow fetching
SHAs directly. Let's take advantage of that where we can by avoiding a
full sync of all the available refs in a remote when it's not needed.

Fall back on a "full sync" if that fails. This is a bit wasteful if
the SHA is truly gone, but it preserves compatibility and will let the
update succeed if GitHub ever changes their minds, or if using another
git server with similar restrictions.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
    @mbolivar-nordic
    mbolivar-nordic committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    b8e7a1c View commit details
    Browse the repository at this point in the history