Add picolibc support #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When assert is used, picolibc will eventually call _exit. Provide a stub for that which spins to cause failing test cases to timeout. Signed-off-by: Keith Packard <keithp@keithp.com>
The compiler need not assume that the only valid values for err are those defined in the enum, so it may think that the function falls off the end. Add an assert(0) to cause the test to fail if that actually happens. The compiler can still validate that all enum values are present in the switch statement, providing the desired diagnostic at compile time. Signed-off-by: Keith Packard <keithp@keithp.com>
When built with -DNDEBUG, the assert in char_to_uint8_t will be disabled causing the function will fall off the end and generating a compiler message. Undefine NDEBUG defined before including <assert.h> to make sure assert is active in this file. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
added a commit
to keith-packard/zephyr
that referenced
this pull request
Dec 4, 2025
This module also needs some small changes to build with picolibc. This has not been merged to the Zephyr tf-m-tests repository yet, that PR is: zephyrproject-rtos/tf-m-tests#17 Signed-off-by: Keith Packard <keithp@keithp.com>
Author
|
The two non-picolibc changes were already in the 2.2.2 branch, so they weren't needed. That leaves only the picolibc stubs; those are not suitable for upstream as upstream is moving away from using libc at all. I've re-submitted that change as #18 and tagged it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series allows these tests to be built using picolibc.
The first patch adds a stub for
_exitso that code can use assert(0) when compiled against picolibc.The other two patches avoid compiler warnings (which become errors when built under twister).