Skip to content

Conversation

andyross
Copy link
Contributor

Add toolchains for mt8186/88 and mt8196. Note that the directory layout of the overlay is slightly different from existing overlays, conforming to the files as shipped by recent (RJ-2024.3) versions of the Cadence tooling. crosstools-ng appears to support both, but this is easier to maintain.

Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comments here are addressed, I will create a topic branch for testing this.

Note that the CI workflow changes in this PR are not reflected in the actual run because it runs as pull_request_target.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an unrelated change.

Comment on lines 1593 to 1594
# Not merged yet, see Zephyr #81154
#PLATFORM_ARGS+="-p mt8195/mt8195/adsp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML needs spaces.

Add toolchains for mt8186/88 and mt8196.  Note that the directory
layout of the overlay is slightly different from existing overlays,
conforming to the files as shipped by recent (RJ-2024.3) versions of
the Cadence tooling.  crosstools-ng appears to support both, but this
is easier to maintain.

Signed-off-by: Andy Ross <andyross@google.com>
@andyross
Copy link
Contributor Author

Fixed

@stephanosio
Copy link
Member

topic-mt8196 branch has been created and a test run has been queued:
https://github.com/zephyrproject-rtos/sdk-ng/actions/runs/12060359421

@stephanosio stephanosio merged commit e3dd6ac into zephyrproject-rtos:main Nov 29, 2024
74 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants