[noup] zephyr: crypto: fix coverity issue #87
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qingling-Wu
requested review from
jukkar,
krish2718,
rlubos and
MaochenWang1
as code owners
jukkar
reviewed
May 30, 2025
|
This also needs a manifest update in zephyr side so that this fix is taken into use, please create a PR in zephyr which updates west.yml file. |
Qingling-Wu
force-pushed
the
main_upstream_ql
branch
from
0c16dc6 to
de2aff1
Compare
jukkar
reviewed
May 30, 2025
| @@ -2650,6 +2650,7 @@ struct wpabuf *crypto_ec_key_get_subject_public_key(struct crypto_ec_key *key) | |||
| /* algorithm AlgorithmIdentifier */ | |||
There was a problem hiding this comment.
and the other
[noup] zephyr: crypto: Fix coverity issue when getting public/private key
Qingling-Wu
force-pushed
the
main_upstream_ql
branch
from
de2aff1 to
b423a92
Compare
krish2718
reviewed
May 30, 2025
Qingling-Wu
force-pushed
the
main_upstream_ql
branch
from
b423a92 to
2d8f54f
Compare
Fix INTEGER_OVERFLOW coverity issue. crypto_ecdh_set_peerkey: The decrement operator on the unsigned variable len might result in an underflow. Check value of the unsigned variable len before decrement. Signed-off-by: Qingling Wu <qingling.wu@nxp.com>
… key Fix INTEGER_OVERFLOW coverity issue. crypto_ec_key_get_subject_public_key/crypto_ec_key_get_ecprivate_key: tainted_data_return: Called function mbedtls_asn1_write_len, and a possible return value is known to be less than zero. overflow: The expression len is considered to have possibly overflowed. Check return value of mbedtls_asn1_write_len and mbedtls_asn1_write_tag, if less than zero, return NULL. Signed-off-by: Qingling Wu <qingling.wu@nxp.com>
Qingling-Wu
force-pushed
the
main_upstream_ql
branch
from
2d8f54f to
8c816c4
Compare
krish2718
approved these changes
May 30, 2025
jukkar
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix INTEGER_OVERFLOW coverity issue.
crypto_ecdh_set_peerkey:
Check value of the unsigned variable len before decrement. crypto_ec_key_get_subject_public_key/crypto_ec_key_get_ecprivate_key: Check return value of mbedtls_asn1_write_len and mbedtls_asn1_write_tag, if less than zero, return NULL.