Skip to content

lib: stm32wba: Fix Link Layer and LE integration on STM32WBA #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vtardy-st
Copy link
Contributor

some header files and system files of the Link Layer in zephyr are not aligned with the header file and system files of the Link Layer in STM32Cube_FW_WBA Release 1.6.0

Update Link Layer and LE porting to be aligned on STM32Cube_FW_WBA Release 1.6.0

Signed-off-by: Vincent Tardy <vincent.tardy@st.com>
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it is unclear why this PR is needed as #280 already aligned lib on v1.6.0. Am I mixing something ?

Comment on lines +9 to +16
* This Synopsys DWC Bluetooth Low Energy Combo Link Layer/MAC software and
* associated documentation ( hereinafter the "Software") is an unsupported
* proprietary work of Synopsys, Inc. unless otherwise expressly agreed to in
* writing between Synopsys and you. The Software IS NOT an item of Licensed
* Software or a Licensed Product under any End User Software License Agreement
* or Agreement for Licensed Products with Synopsys or any supplement thereto.
* Synopsys is a registered trademark of Synopsys, Inc. Other names included in
* the SOFTWARE may be the trademarks of their respective owners.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Zephyr licence compatibility purposes, files in this module where updated to the latest License which doesn't contain these lines. Please keep it as is. Apply to all files
See #262.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should reflect Cube package library and changes should be documented and justified, ideally one by commit and
in this particular case, I think a deeper discussion is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants