sensor: lsm6dso: Disable -Wmaybe-uninitialized for lsm6dso_mode_set #11
Conversation
|
Depending on how the library is updated, I'd suggest adding a "Patch list" section in the README of this component to avoid erasing this patch on component update. See https://github.com/zephyrproject-rtos/hal_stm32/tree/main/stm32cube/stm32l4xx/README for instance. |
stephanosio
force-pushed
the
fix_lsm6dso_maybeuninit
branch
from
e33da73 to
19dfa16
Compare
@erwango Done. https://github.com/zephyrproject-rtos/hal_st/pull/11/files#diff-81dc8b8891ba007ea61b440ccd1f34c8fcf17d110f3eef6f96c28aa81a7ff5deR60-R61 |
This commit disables the potentially uninitialized variable warning (`-Wmaybe-uninitialized`) for the `lsm6dso_mode_set` function because GCC 12 and above may report a false positive warning claiming that the `ctrl2_ois` variable may be used uninitialized. Note that the `ctrl2_ois` variable is always set when `aux_ctx != NULL` and is accessed if and only if `aux_ctx != NULL`, therefore it may never be used uninitialized as the warning claims. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
stephanosio
force-pushed
the
fix_lsm6dso_maybeuninit
branch
from
19dfa16 to
a22b81d
Compare
|
@erwango shall we merge this now? |
|
@stephanosio I'd like to follow the process and get a second +1, if time permits. @avisconti Would you mind having a quick look ? |
|
@avisconti or anyone else, please review. we will be switching to the Zephyr SDK 0.15.0 very soon and this needs to go in before that. |
3 participants
This commit disables the potentially uninitialized variable warning
(
-Wmaybe-uninitialized) for thelsm6dso_mode_setfunction becauseGCC 12 and above may report a false positive warning claiming that the
ctrl2_oisvariable may be used uninitialized.Note that the
ctrl2_oisvariable is always set whenaux_ctx != NULLand is accessed if and only if
aux_ctx != NULL, therefore it maynever be used uninitialized as the warning claims.
Signed-off-by: Stephanos Ioannidis root@stephanos.io
NOTE: This is required for the upcoming Zephyr SDK 0.15.0 release.