Siwx91x pm #103
Open
Siwx91x pm #103
+13,104
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fimohame
requested review from
jhedberg,
asmellby,
jerome-pouiller and
Martinhoff-maker
as code owners
|
What commit hash and version of Wiseconnect is this imported from? The fact that some existing files have a diff suggests that the import may be from a wrong version. |
fimohame
force-pushed
the
siwx91x-pm
branch
4 times, most recently
from
eb9209d to
052a666
Compare
fimohame
force-pushed
the
siwx91x-pm
branch
6 times, most recently
from
b7d950c to
0596de8
Compare
|
I have updated it, also added a pach commit |
jerome-pouiller
requested changes
May 20, 2025
There was a problem hiding this comment.
In the commit log of wiseconnect: Power Manager SDK files, : should be followed by a space.
I also try to uniformize the commit titles. So, commit wiseconnect: import_wiseconnect.py update should be start with scripts: .
wiseconnect_sdk: Patch for sl_si91x_m4_ps.h should start with wiseconnect: .
Also note this PR can't be merged while it imports MSLA files.
wiseconnect/components/device/silabs/si91x/mcu/drivers/unified_api/src/sl_si91x_i2s.c
Outdated
Show resolved
Hide resolved
wiseconnect/components/device/silabs/si91x/mcu/core/chip/src/rsi_ps_ram_func.c
Outdated
Show resolved
Hide resolved
wiseconnect/components/device/silabs/si91x/mcu/core/common/inc/rsi_debug.h
Outdated
Show resolved
Hide resolved
wiseconnect/components/device/silabs/si91x/mcu/core/common/src/rsi_debug.c
Outdated
Show resolved
Hide resolved
wiseconnect/components/device/silabs/si91x/mcu/drivers/cmsis_driver/SAI.c
Show resolved
Hide resolved
wiseconnect/components/device/silabs/si91x/mcu/drivers/cmsis_driver/UDMA.c
Outdated
Show resolved
Hide resolved
fimohame
force-pushed
the
siwx91x-pm
branch
4 times, most recently
from
1e6c1d4 to
3ce249f
Compare
|
I don't know if it's supposed to be resolved now but still some files with MSLA licenses |
fimohame
force-pushed
the
siwx91x-pm
branch
3 times, most recently
from
874e1e4 to
35c5bbc
Compare
Origin: Silicon Labs WiseConnect SDK License: Zlib and Apache-2.0 URL: https://github.com/siliconlabs/wiseconnect Commit: 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e Version: v3.5.0-rc3 Purpose: Add Power Manager support for SiWx917 Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>
Add powermanager sdk files in import_wiseconnect.py Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>
guard sl_event_handler.h inclusion and declared sli_si91x_m4_ta_wakeup_configurations() in sl_si91x_m4_ps.h Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>
Added Zlib license clause to the sl_si91x_m4_ps.h file Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>
Added Zlib license clause to the rsi_debug.h file Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>
Added Zlib license clause to the rsi_debug.c file Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>
Added Zlib license clause to the UDMA.c file Signed-off-by: S Mohamed Fiaz <fiaz.mohamed@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin: Silicon Labs WiseConnect SDK
License: Zlib and Apache-2.0
URL: https://github.com/siliconlabs/wiseconnect
Commit: 05ef77e82bb473fdf157d33fb9cbf6e1d9a11a9e
Version: v3.5.0-rc3
Purpose: Add Power Manager support for SiWx917