arm_biquad_cascade_df1_32x64_q31: asrl(val, -shift) -> lsll(val, shift) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
…t) (ARM-software#265) This code was using asrl with an intentionally negative value. GCC 14 doesn't turn that into a left shift, instead it produces 0 for the result. Use lsll instead to get the desired result. Signed-off-by: Keith Packard <keithp@keithp.com> (cherry picked from commit b7a49ac)
keith-packard
force-pushed
the
avoid-negative-shift
branch
from
04de9e1 to
2cc3a62
Compare
keith-packard
added a commit
to keith-packard/zephyr
that referenced
this pull request
Aug 11, 2025
This patch has been accepted upstream ARM-software/CMSIS-DSP#265. The module PR, zephyrproject-rtos/cmsis-dsp#7 is pending review. Signed-off-by: Keith Packard <keithp@keithp.com>
stephanosio
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was using asrl with an intentionally negative value. GCC 14 doesn't turn that into a left shift, instead it produces 0 for the result.
Use lsll instead to get the desired result.
(cherry picked from commit b7a49ac)
Upstream PR: ARM-software#265 (closed)