Skip to content

microblaze: Invalid data offsets (pointer) after relaxation. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alpsayin
Copy link

@alpsayin alpsayin commented Mar 1, 2023

Proposed patch from community member (dednev@rambler.ru) against 2021.1
[CR-1115232]

Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>

Patch file taken and partially applied from:
https://github.com/Xilinx/meta-xilinx/blob/master/meta-microblaze/recipes-devtools/binutils/binutils/0038-Invalid-data-offsets-pointer-after-relaxation.-Propo.patch
Signed-off-by: Alp Sayin <alpsayin@gmail.com>
@stephanosio
Copy link
Member

@alpsayin Can you take this out of draft it is ready to go in?

@alpsayin
Copy link
Author

alpsayin commented Mar 6, 2023

@stephanosio Sorry, I grabbed the toolchain but I haven't yet got the time to test it. I'll get on it 🤞🏼

@alpsayin alpsayin marked this pull request as ready for review March 8, 2023 16:09
@alpsayin
Copy link
Author

alpsayin commented Mar 8, 2023

I can't believe this actually worked... But I'm also very happy that it worked.
log_stress tests are now passing.

Zephyr version: zephyr-v3.3.0-371-g6dbd8d347229
Zephyr SDK version: zephyr-sdk-0.16.0-beta1-7-g2a8106a
INFO    - 1990/1990 qemu_microblaze           tests/crypto/mbedtls/crypto.mbedtls                 FAILED Timeout (qemu 399.982s)
ERROR   - see: /scratch/twister_asayin/twister_out/qemu_microblaze/tests/crypto/mbedtls/crypto.mbedtls/handler.log

INFO    - 2182 test scenarios (1990 test instances) selected, 1621 configurations skipped (1451 by static filter, 170 at runtime).
INFO    - 368 of 1990 test configurations passed (99.73%), 1 failed, 0 errored, 1621 skipped with 0 warnings in 2151.63 seconds
INFO    - In total 2832 test cases were executed, 6081 skipped on 1 out of total 543 platforms (0.18%)
INFO    - 330 test configurations executed on platforms, 39 test configurations were only built.

p.s.1 mbedtls error is related to zephyrproject-rtos/mbedtls#38
p.s.2 I'm proceeding to the picolibc issue now.

@stephanosio stephanosio merged commit 1cdd114 into zephyrproject-rtos:zephyr-binutils-2_38 Mar 8, 2023
@alpsayin alpsayin deleted the microblaze_invalid_offset_fix branch March 8, 2023 17:00
alpsayin added a commit to alpsayin/sdk-ng that referenced this pull request Mar 8, 2023
This commit pulls in the fix for the Microblaze linker relaxation issue
causing invalid data offsets (e.g. pointers to struct members) as part of
zephyrproject-rtos/binutils-gdb#7

Signed-off-by: Alp Sayin <alpsayin@gmail.com>
alpsayin added a commit to alpsayin/sdk-ng that referenced this pull request Mar 8, 2023
This commit pulls in the patch for enabling picolibc meson build for
Microblaze with `microblazeel-zephyr-elf` toolchain.
zephyrproject-rtos/binutils-gdb#7

Signed-off-by: Alp Sayin <alpsayin@gmail.com>
stephanosio pushed a commit to alpsayin/sdk-ng that referenced this pull request Mar 9, 2023
This commit pulls in the fix for the Microblaze linker relaxation issue
causing invalid data offsets (e.g. pointers to struct members) as part of
zephyrproject-rtos/binutils-gdb#7

Signed-off-by: Alp Sayin <alpsayin@gmail.com>
stephanosio pushed a commit to zephyrproject-rtos/sdk-ng that referenced this pull request Mar 9, 2023
This commit pulls in the fix for the Microblaze linker relaxation issue
causing invalid data offsets (e.g. pointers to struct members) as part of
zephyrproject-rtos/binutils-gdb#7

Signed-off-by: Alp Sayin <alpsayin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants