action: do not re-install ninja #57
Conversation
After many years asking, Github runners finally got ninja by default in April 2025: - actions/runner-images#11235 So, stop re-installing ninja - at least not unless there is a specific and documented reason to do so. This saves a little bit of time and fixes the following warning in hello_world_multiplatform.yaml: https://github.com/zephyrproject-rtos/zephyr/actions/runs/19853412716 ``` build (macos-14) ninja 1.13.2 is already installed and up-to-date. To reinstall 1.13.2, run: brew reinstall ninja ``` Do not change the Windows build yet because the build environment is always much more complicated on Windows, so let's first make sure this is fine on Linux and macOS. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
Just testing zephyrproject-rtos/action-zephyr-setup#57 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
Successfully tested in Zephyr test PR https://github.com/zephyrproject-rtos/zephyr/actions/runs/19874863459/job/56959638224?pr=100403 Warning is gone (and everything still builds and runs fine). 
|
|
@fabiobaltieri , @henrikbrixandersen this repo does not seem to automatically add reviewers. |
|
Could this cause a regression for users of private runners? If on Linux it does not save any time it may be a good idea to leave it there, feels a bit undefensive to remove a package. |
|
Has this action ever been used outside https://github.com/actions/runner-images ? If it has, then those other runners already had to mimic GH runners-provided dependencies by trial and error anyway. I mean it does not look like action-zephyr-setup has a documented list of prerequisites, has it? tl;dr: this sounds very "theoretical". |
I don't think this is a big deal, to be honest. I doubt many users are using this action with self-hosted runners, and if they are - as already pointed out by @marc-hb - we have not previously provided a list of dependencies to be installed (except for the one(s) in the Zephyr Getting Started Guide, which includes Ninja). |
|
We did have reports from people running this with private runners, definitely not a big deal but if the impact on linux is just a "package already installed" it's worth considering it. Anyway, if one has a custom runner and is diverging from the github image on the basic tool they are probably going to have load of other issues, let's give it a try see if anyone complains and we can learn from it I guess. This is meant to be "minimal" after all. |
3 participants
After many years asking, Github runners finally got ninja by default in April 2025:
So, stop re-installing ninja - at least not unless there is a specific and documented reason to do so. This saves a little bit of time and fixes the following warning in hello_world_multiplatform.yaml:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/19853412716
Do not change the Windows build yet because the build environment is always much more complicated on Windows, so let's first make sure this is fine on Linux and macOS.