Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2276 - Add support for mixed type #2288

Merged
merged 8 commits into from
Oct 5, 2021
Merged

#2276 - Add support for mixed type #2288

merged 8 commits into from
Oct 5, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Sep 18, 2021 •
edited
Loading

Hello!

  • Type: new feature
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Thanks

@Jeckerson Jeckerson added the nfr New Feature Request label Sep 18, 2021
@Jeckerson Jeckerson self-assigned this Sep 18, 2021
@Jeckerson Jeckerson linked an issue Sep 18, 2021 that may be closed by this pull request
[NFR] Add support for mixed return type (PHP >= 8.0) #2276
Closed
@codecov
Copy link

codecov bot commented Sep 18, 2021 •
edited
Loading

Codecov Report

Merging #2288 (3ecf7f3) into development (4ef01e4) will decrease coverage by 0.37%.
The diff coverage is 20.54%.

❗ Current head 3ecf7f3 differs from pull request most recent head 477bc37. Consider uploading reports for the commit 477bc37 to get more accurate results

@@               Coverage Diff                @@
##             development   #2288      +/-   ##
================================================
- Coverage           8.15%   7.78%   -0.38%     
- Complexity          8592    8648      +56     
================================================
  Files                357     358       +1     
  Lines              22216   21795     -421     
================================================
- Hits                1811    1696     -115     
+ Misses             20405   20099     -306

@Jeckerson
Copy link
Member Author

In draft until resolution of small bug fixes.

@Jeckerson Jeckerson added Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details hacktoberfest-accepted labels Oct 5, 2021
@Jeckerson
Merge branch 'development' into #2276-mixed-type
a704e34 
# Conflicts:
#	CHANGELOG.md
#	Library/ArgInfoDefinition.php
#	Library/ClassMethod.php
#	Library/Expression.php
#	Library/Statements/ReturnStatement.php
@Jeckerson
#2276 - Refactor Closure class
477bc37
@Jeckerson Jeckerson marked this pull request as ready for review October 5, 2021 14:41
@Jeckerson Jeckerson merged commit a41cb40 into development Oct 5, 2021
@Jeckerson Jeckerson deleted the #2276-mixed-type branch October 5, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees

@Jeckerson Jeckerson

Labels
Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details hacktoberfest-accepted nfr New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR] Add support for mixed return type (PHP >= 8.0)
2 participants
@Jeckerson @niden