Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable regression changes #1954

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Conversation

sergeyklay
Copy link
Contributor

@sergeyklay sergeyklay commented Oct 5, 2019

Changes introduced in the 11dc1d4 completely broke Phalcon just by one line PHP script:

<?php
$di = new Phalcon\Di;

Refs:

/cc @dreamsxin

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #1954 into development will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             development    #1954      +/-   ##
=================================================
- Coverage          33.97%   33.94%   -0.03%     
  Complexity          8252     8252              
=================================================
  Files                561      561              
  Lines              44930    44920      -10     
=================================================
- Hits               15264    15250      -14     
- Misses             29666    29670       +4

@sergeyklay sergeyklay merged commit 776262a into development Oct 5, 2019
@sergeyklay sergeyklay deleted the fix/update-static-property branch October 5, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant