Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added new feature support variable-length argument in functions #1100

Closed
wants to merge 2 commits into from

Conversation

KorsaR-ZN
Copy link
Contributor

@KorsaR-ZN KorsaR-ZN commented Sep 29, 2015

New syntax, see #938, #1662

public function test1(int a, int b, ...args) 
{
    // expr
}

public function test2(int a, int b, int ...args) 
{
    // expr
}

public function test3(int a, int b, int! ...args) 
{
    // expr
}

public function test4(int a, int b, <\StdClass> ...args) 
{
    // expr
}

Progress list

  • Add parsing new syntax
  • Add compiling new syntax
  • Add tests

@Green-Cat
Copy link
Contributor

👍

@Yahasana
Copy link

Hello reviewers, where r u

@niden
Copy link
Contributor

niden commented Sep 15, 2018

@KorsaR-ZN Thank you for this!

Would you mind checking the branch? It appears there is a conflict in parser.lemon that needs to be resolved.

We will check this as soon as we can.

@sergeyklay sergeyklay self-assigned this Sep 18, 2018
@sandrokeil
Copy link

Are there any news for this?

@sergeyklay
Copy link
Contributor

@sandrokeil I'll take look in the next week

@sandrokeil
Copy link

ping @sergeyklay ;-)

@sergeyklay
Copy link
Contributor

@sandrokeil I'm work on #1779 right now. Next I want to close some other urgent issues. If anyone wants to get started, I'd love that.

@Ragdata
Copy link

Ragdata commented Jan 27, 2020

Hey, sorry to be 'that guy' - does it look like there'll be any movement on this task in the near future?

Looking at the project commit logs, it looks as though there's really only a handful of people contributing to the project - should I brush up some C skills and jump into the fray?

@sergeyklay
Copy link
Contributor

@Ragdata It would be helpful anyway :)

@sergeyklay sergeyklay removed their assignment Sep 7, 2020
@Jeckerson Jeckerson closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nfr New Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants