-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.12.5] broken build #1940
Comments
Seeing something similar in Nanobox with Phalcon
|
@remicollet Does adding |
@sergeyklay it is already included. |
@remicollet I'll fix this ASAP. Could you provide steps to reproduce this issue? Unfortunately, tests are passed successfully, so I didn't known about this problem |
I have a branch ready:
|
@ruudboon In general I need reproducible steps I can add to current .travis.yml |
@remicollet Do you have some more information about your environment? Are you also using nanobox? |
@remicollet It seems I found the root of problem. Do you have ext-json installed/enabled?
Take a look at zephir_json_decode: #ifdef ZEPHIR_USE_PHP_JSON
// Some code here
// ...
/// ...
#else
int zephir_json_encode(zval *return_value, zval *v, int opts)
{
zval zopts;
zval *params[2];
ZEPHIR_INIT_VAR(&zopts);; // <------ Line 1194 (previously ZEPHIR_SINIT_VAR(zopts))
ZVAL_LONG(&zopts, opts);
params[0] = v;
params[1] = &zopts;
return zephir_return_call_function(return_value, SL("json_encode"), NULL, 0, 2, params);
}
// Some code here
// ...
/// ...
#endif /* ZEPHIR_USE_PHP_JSON */ Then take a look at #define zephir_memory_observe(var) zephir_do_memory_observe(var, ZEPHIR_METHOD_GLOBALS_PTR);
#define ZEPHIR_INIT_VAR(z) \
zephir_memory_observe(z); \ // <----- ./kernel/memory.h:94:2: note
ZVAL_NULL(z); Looks like @remicollet and @ruudboon uses |
@dreamsxin I used Hopefully it can be at help. Thank you. |
@ruudboon @remicollet I need your config.h. Could you please share the content |
ext\config.h
|
@dreamsxin Do you see ^ /* Whether PHP json extension is present at compile time */
/* #undef ZEPHIR_USE_PHP_JSON */ |
The issue was in: $ grep -c '#define HAVE_JSON 1' $(phpenv prefix)/include/php/main/php_config.h
1 I'm pretty sure @remicollet and @ruudboon does not have HAVE_JSON constant or it set to 0 |
Fixed in the |
Still encounter the same issue with 0.12.6 Also "zephir api" raise an error Full output
|
Notice config.h have
Which is obviously wrong. |
@remicollet I've fixed this right now. Could you please try development branch by any chance? Note, you'll need clone this repo, switch to the |
I confirm using master at 98c5a73 |
@remicollet Just released 0.12.7 version: https://github.com/phalcon/zephir/releases/tag/0.12.7 |
Closes: zephir-lang#1944 Fixes: zephir-lang#1940 Refs: - zephir-lang@0922dad
The text was updated successfully, but these errors were encountered: