Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect debug when building #1520

Closed
Jurigag opened this issue Apr 21, 2017 · 2 comments
Closed

Detect debug when building #1520

Jurigag opened this issue Apr 21, 2017 · 2 comments
Assignees

Comments

@Jurigag
Copy link
Contributor

Jurigag commented Apr 21, 2017

I have a small idea, sometimes i forgot to write builddev when i need to, how about:

  • detect if we have php compiled as debug
  • if yes then zephir build will always build extension with debug symbols(just zephir builddev)
  • if not then as it is
  • add zephir buildprod so someone can build extension without debug symbols anyway
@sjinks
Copy link
Contributor

sjinks commented Aug 2, 2017

if (PHP_DEBUG) {
// ...
}

PHP_DEBUG constant is available since PHP 5.2.7

@sergeyklay
Copy link
Contributor

Implemented in the 0.11.x branch

sergeyklay added a commit that referenced this issue Nov 17, 2018
sergeyklay added a commit that referenced this issue Nov 17, 2018
sergeyklay added a commit that referenced this issue Nov 17, 2018
sergeyklay added a commit that referenced this issue Nov 18, 2018
sergeyklay added a commit that referenced this issue Nov 18, 2018
sergeyklay added a commit that referenced this issue Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants