Update tests for #1494

zephir-lang · Nov 2, 2019 · fe4bce3 · fe4bce3
1 parent abb5227
commit fe4bce3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 16 deletions.
diff --git a/test/spropertyaccess.zep b/test/spropertyaccess.zep
@@ -41,9 +41,6 @@ class SPropertyAccess
 		return delimiter;
 	}
 
-	/**
-	 * @see https://github.com/phalcon/zephir/issues/1494
-	 */
 	public static function mutateStringVarInsideCycle() -> string
 	{
 		var i;
@@ -64,8 +61,8 @@ class SPropertyAccess
 		var i;
 
 		for _ in range(0, 3) {
-			let i = 2;
-			let self::intVar = self::intVar + i;
+			let i = 42;
+			let self::intVar = i;
 		}
 
 		return self::intVar;
@@ -79,16 +76,13 @@ class SPropertyAccess
 		var i;
 
 		for _ in range(0, 3) {
-			let i = 2.1;
-			let self::doubleVar = self::doubleVar + i;
+			let i = 3.14;
+			let self::doubleVar = i;
 		}
 
 		return self::doubleVar;
 	}
 
-	/**
-	 * @see https://github.com/phalcon/zephir/issues/1494
-	 */
 	public static function mutateArrayVarInsideCycle() -> array
 	{
 		var i, j;

diff --git a/unit-tests/Extension/SPropertyAccessTest.php b/unit-tests/Extension/SPropertyAccessTest.php
@@ -32,8 +32,6 @@ public function testStaticPropertyAccessWithUnderscore()
 
     /**
      * @test
-     *
-     * @see https://github.com/phalcon/zephir/issues/1494
      */
     public function shouldMutateStringVarInsideCycle()
     {
@@ -51,7 +49,7 @@ public function shouldMutateStringVarInsideCycle()
     public function shouldMutateIntVarInsideCycle()
     {
         $this->assertEquals(
-            8,
+            42,
             SPropertyAccess::mutateIntVarInsideCycle()
         );
     }
@@ -64,15 +62,13 @@ public function shouldMutateIntVarInsideCycle()
     public function shouldMutateDoubleVarInsideCycle()
     {
         $this->assertEquals(
-            8.4,
+            3.14,
             SPropertyAccess::mutateDoubleVarInsideCycle()
         );
     }
 
     /**
      * @test
-     *
-     * @see https://github.com/phalcon/zephir/issues/1494
      */
     public function shouldMutateArrayVarInsideCycle()
     {