Merge pull request #2123 from phalcon/bugfix/implode-params-for-php74

Bugfix/implode params for php74
zephir-lang · Nov 20, 2020 · dbc3942 · dbc3942
2 parents 732e9be + 52d81b2
commit dbc3942
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org).
 ## [Unreleased]
 ### Fixed
 - Fixed stubs generation for case with array declaration with square brackets in params
+- Fixed parameters positioning for `implode()` php function [#2120](https://github.com/phalcon/zephir/issues/2120)
 
 ## [0.12.19] - 2020-05-13
 ### Fixed

diff --git a/Library/Compiler.php b/Library/Compiler.php
@@ -859,7 +859,7 @@ public function compile($development = false)
                 $hasChanged = false;
 
                 if (false === strpos($configureFile, $fixMarker)) {
-                    $configureFile = $fixMarker.PHP_EOL.implode($configureFix, PHP_EOL).PHP_EOL.$configureFile;
+                    $configureFile = $fixMarker.PHP_EOL.implode(PHP_EOL, $configureFix).PHP_EOL.$configureFile;
                     $hasChanged = true;
                 }
 

diff --git a/Library/CompilerFileAnonymous.php b/Library/CompilerFileAnonymous.php
@@ -132,7 +132,7 @@ private function compileClass(CompilationContext $compilationContext)
         }
 
         if (\count($this->headerCBlocks) > 0) {
-            $code .= implode($this->headerCBlocks, PHP_EOL).PHP_EOL;
+            $code .= implode(PHP_EOL, $this->headerCBlocks).PHP_EOL;
         }
 
         /*