Skip to content

Conversation

Jeckerson
Copy link
Member

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Thanks

@Jeckerson Jeckerson self-assigned this Sep 28, 2025
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.69%. Comparing base (1383bd6) to head (a20afd3).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
parser/zephir.lemon 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   76.72%   76.69%   -0.03%     
==========================================
  Files           5        5              
  Lines        3029     3030       +1     
  Branches      128      128              
==========================================
  Hits         2324     2324              
- Misses        705      706       +1     
Flag Coverage Δ
Linux 76.69% <28.57%> (-0.03%) ⬇️
unittests 76.69% <28.57%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jeckerson Jeckerson requested a review from niden September 28, 2025 11:43
@Jeckerson Jeckerson marked this pull request as ready for review September 28, 2025 11:43
@Jeckerson Jeckerson linked an issue Sep 28, 2025 that may be closed by this pull request
@Jeckerson Jeckerson merged commit fd38e28 into master Sep 28, 2025
64 of 66 checks passed
@Jeckerson Jeckerson deleted the #166-single-char-class branch September 28, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class names consisting of one letter are not allowed
1 participant