Skip to content

feat: auto ORM reset mode #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions src/ORM/ResetDatabase/AutoDatabaseResetter.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
<?php

namespace Zenstruck\Foundry\ORM\ResetDatabase;

use Doctrine\Bundle\DoctrineBundle\Registry;
use Doctrine\Migrations\DependencyFactory;
use Symfony\Component\HttpKernel\KernelInterface;

/**
* @author Kevin Bond <kevinbond@gmail.com>
* @internal
*/
final class AutoDatabaseResetter implements OrmResetter
{
private OrmResetter $inner;

Check failure on line 15 in src/ORM/ResetDatabase/AutoDatabaseResetter.php

View workflow job for this annotation

GitHub Actions / Static Analysis

Class Zenstruck\Foundry\ORM\ResetDatabase\AutoDatabaseResetter has an uninitialized property $inner. Give it default value or assign it in the constructor.

/**
* @param list<string> $configurations
*/
public function __construct(

Check failure on line 20 in src/ORM/ResetDatabase/AutoDatabaseResetter.php

View workflow job for this annotation

GitHub Actions / Static Analysis

Method Zenstruck\Foundry\ORM\ResetDatabase\AutoDatabaseResetter::__construct() has parameter $managers with no value type specified in iterable type array.

Check failure on line 20 in src/ORM/ResetDatabase/AutoDatabaseResetter.php

View workflow job for this annotation

GitHub Actions / Static Analysis

Method Zenstruck\Foundry\ORM\ResetDatabase\AutoDatabaseResetter::__construct() has parameter $connections with no value type specified in iterable type array.
private readonly array $configurations,
private Registry $registry,
private array $managers,
private array $connections,
private ?DependencyFactory $dependencyFactory,
) {
}

public function resetBeforeFirstTest(KernelInterface $kernel): void
{
$this->inner()->resetBeforeFirstTest($kernel);
}

public function resetBeforeEachTest(KernelInterface $kernel): void
{
$this->inner()->resetBeforeEachTest($kernel);
}

private function inner(): OrmResetter
{
if (isset($this->inner)) {
return $this->inner;
}

if (!$this->hasMigrations()) {
return $this->inner = new SchemaDatabaseResetter(
$this->registry,
$this->managers,

Check failure on line 48 in src/ORM/ResetDatabase/AutoDatabaseResetter.php

View workflow job for this annotation

GitHub Actions / Static Analysis

Parameter #2 $managers of class Zenstruck\Foundry\ORM\ResetDatabase\SchemaDatabaseResetter constructor expects list<string>, array given.
$this->connections,

Check failure on line 49 in src/ORM/ResetDatabase/AutoDatabaseResetter.php

View workflow job for this annotation

GitHub Actions / Static Analysis

Parameter #3 $connections of class Zenstruck\Foundry\ORM\ResetDatabase\SchemaDatabaseResetter constructor expects list<string>, array given.
);
}

return $this->inner = new MigrateDatabaseResetter(
$this->configurations,
$this->registry,
$this->managers,

Check failure on line 56 in src/ORM/ResetDatabase/AutoDatabaseResetter.php

View workflow job for this annotation

GitHub Actions / Static Analysis

Parameter #3 $managers of class Zenstruck\Foundry\ORM\ResetDatabase\MigrateDatabaseResetter constructor expects list<string>, array given.
$this->connections,

Check failure on line 57 in src/ORM/ResetDatabase/AutoDatabaseResetter.php

View workflow job for this annotation

GitHub Actions / Static Analysis

Parameter #4 $connections of class Zenstruck\Foundry\ORM\ResetDatabase\MigrateDatabaseResetter constructor expects list<string>, array given.
);
}

private function hasMigrations(): bool
{
if (!$this->dependencyFactory) {
return false;
}

return 0 !== $this->dependencyFactory->getMigrationPlanCalculator()->getMigrations()->count();
}
}
6 changes: 6 additions & 0 deletions src/ORM/ResetDatabase/ResetDatabaseMode.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,10 @@ enum ResetDatabaseMode: string
{
case SCHEMA = 'schema';
case MIGRATE = 'migrate';
case AUTO = 'auto';

public function requiresMigrationConfiguration(): bool
{
return self::SCHEMA !== $this;
}
}
11 changes: 10 additions & 1 deletion src/ZenstruckFoundryBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use Symfony\Component\DependencyInjection\ChildDefinition;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\DependencyInjection\Exception\LogicException;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symfony\Component\DependencyInjection\Reference;
Expand All @@ -25,6 +26,7 @@
use Zenstruck\Foundry\InMemory\InMemoryRepository;
use Zenstruck\Foundry\Mongo\MongoResetter;
use Zenstruck\Foundry\Object\Instantiator;
use Zenstruck\Foundry\ORM\ResetDatabase\AutoDatabaseResetter;
use Zenstruck\Foundry\ORM\ResetDatabase\MigrateDatabaseResetter;
use Zenstruck\Foundry\ORM\ResetDatabase\OrmResetter;
use Zenstruck\Foundry\ORM\ResetDatabase\ResetDatabaseMode;
Expand Down Expand Up @@ -404,10 +406,17 @@ private function configureOrm(ContainerConfigurator $configurator, ContainerBuil
match ($resetMode) {
ResetDatabaseMode::SCHEMA => SchemaDatabaseResetter::class,
ResetDatabaseMode::MIGRATE => MigrateDatabaseResetter::class,
ResetDatabaseMode::AUTO => AutoDatabaseResetter::class,
}
);

if (ResetDatabaseMode::MIGRATE === $resetMode) {
if (ResetDatabaseMode::AUTO === $resetMode) {
$container->getDefinition(OrmResetter::class)
->replaceArgument('$dependencyFactory', new Reference('doctrine.migrations.dependency_factory', ContainerInterface::NULL_ON_INVALID_REFERENCE));
;
}

if ($resetMode->requiresMigrationConfiguration()) {
$container->getDefinition(OrmResetter::class)
->replaceArgument('$configurations', $ormConfig['reset']['migrations']['configurations']);
}
Expand Down
Loading