Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Oct 15, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

📝 Walkthrough

Walkthrough

Bumps JetBrains IDE plugin version from 2.20.0 to 2.20.1 and updates a TypeScript enhancer overload to conditionally apply PrismaClient generics based on whether the new Prisma client generator is used.

Changes

Cohort / File(s) Summary
JetBrains plugin version
packages/ide/jetbrains/build.gradle.kts
Updated project version: 2.20.0 → 2.20.1.
Enhancer PrismaClient generics
packages/schema/src/plugins/enhancer/enhance/index.ts
Adjusted PrismaClient overload to conditionally include legacy generics (<any, any, ExtArgs>) when not using the new Prisma client generator; unchanged for the new generator.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is empty and does not provide any context or information about the changes, so it fails the requirement to describe the modifications in the changeset. Please add a brief description summarizing the changes made, such as the conditional adjustment to the PrismaClient generics and the version bump, to provide context for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title succinctly describes the primary change as a fix for a typing issue in the Prisma client generator and is clear, concise, and directly related to the code modifications without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/prisma-client-gen

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eacdf10 and 83cc8e6.

⛔ Files ignored due to path filters (13)
  • package.json is excluded by !**/*.json
  • packages/ide/jetbrains/package.json is excluded by !**/*.json
  • packages/language/package.json is excluded by !**/*.json
  • packages/misc/redwood/package.json is excluded by !**/*.json
  • packages/plugins/openapi/package.json is excluded by !**/*.json
  • packages/plugins/swr/package.json is excluded by !**/*.json
  • packages/plugins/tanstack-query/package.json is excluded by !**/*.json
  • packages/plugins/trpc/package.json is excluded by !**/*.json
  • packages/runtime/package.json is excluded by !**/*.json
  • packages/schema/package.json is excluded by !**/*.json
  • packages/sdk/package.json is excluded by !**/*.json
  • packages/server/package.json is excluded by !**/*.json
  • packages/testtools/package.json is excluded by !**/*.json
📒 Files selected for processing (2)
  • packages/ide/jetbrains/build.gradle.kts (1 hunks)
  • packages/schema/src/plugins/enhancer/enhance/index.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: build-test (20.x)
  • GitHub Check: build-test (20.x)
  • GitHub Check: build-test (20.x)
  • GitHub Check: dependency-review
  • GitHub Check: OSSAR-Scan
🔇 Additional comments (3)
packages/ide/jetbrains/build.gradle.kts (1)

12-12: LGTM! Version bump aligns with the release.

The version increment from 2.20.0 to 2.20.1 is appropriate for a patch release addressing the typing issue.

packages/schema/src/plugins/enhancer/enhance/index.ts (2)

343-343: LGTM! Conditional generic parameters align with generator versions.

The change correctly adjusts the type signature based on the Prisma generator version:

  • New generator (prisma-client): No generic parameters on _PrismaClient
  • Old generator (prisma-client-js): Requires <any, any, ExtArgs> generics

This ensures type compatibility with the actual imported _PrismaClient type.


372-378: Handle non-generic _PrismaClient in Enhanced type
The condition Client extends _PrismaClient<any, any, any> won’t match a non-generic _PrismaClient. Verify your Prisma client generator’s _PrismaClient signature and add a branch for Client extends _PrismaClient (no generics) if needed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ymc9 ymc9 merged commit 2918884 into dev Oct 15, 2025
12 of 13 checks passed
@ymc9 ymc9 deleted the fix/prisma-client-gen branch October 15, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant