Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Aug 9, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 9, 2025

📝 Walkthrough

Walkthrough

The changes update the import path for the fromZodError function across multiple files, switching from the root zod-validation-error package to the version-specific zod-validation-error/v3 subpath. No logic, functionality, or public API is altered; only import statements are modified.

Changes

Cohort / File(s) Change Summary
OpenAPI Generator Import Update
packages/plugins/openapi/src/generator-base.ts
Changed import of fromZodError to use zod-validation-error/v3 subpath.
Runtime Node Policy Imports
packages/runtime/src/enhancements/node/policy/handler.ts,
packages/runtime/src/enhancements/node/policy/policy-utils.ts
Updated fromZodError import to zod-validation-error/v3; reordered local helper imports in handler.ts.
Runtime Validation Import
packages/runtime/src/validation.ts
Changed fromZodError import to use zod-validation-error/v3 subpath.
Schema CLI Config Import
packages/schema/src/cli/config.ts
Updated fromZodError import to zod-validation-error/v3.
Server API Imports
packages/server/src/api/rest/index.ts,
packages/server/src/api/rpc/index.ts
Changed fromZodError import to use zod-validation-error/v3 in both files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-zod-validation-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (2)
packages/runtime/src/enhancements/node/policy/handler.ts (1)

18-18: Import reorder of local helpers is a no-op

Only ordering changed (invariant first). No functional impact.

For consistency, ensure import ordering follows the repo’s ESLint/Prettier rules, if any.

packages/runtime/src/enhancements/node/policy/policy-utils.ts (1)

5-5: Updated to zod-validation-error/v3 — approved

Compatible with existing usages in logs and error messages.

Optional: standardize on fromZodError(err).message across the codebase for consistency and to avoid relying on implicit toString().

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3272280 and 9405ff6.

⛔ Files ignored due to path filters (6)
  • packages/plugins/openapi/package.json is excluded by !**/*.json
  • packages/runtime/package.json is excluded by !**/*.json
  • packages/schema/package.json is excluded by !**/*.json
  • packages/server/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
  • pnpm-workspace.yaml is excluded by !**/*.yaml
📒 Files selected for processing (7)
  • packages/plugins/openapi/src/generator-base.ts (1 hunks)
  • packages/runtime/src/enhancements/node/policy/handler.ts (2 hunks)
  • packages/runtime/src/enhancements/node/policy/policy-utils.ts (1 hunks)
  • packages/runtime/src/validation.ts (1 hunks)
  • packages/schema/src/cli/config.ts (1 hunks)
  • packages/server/src/api/rest/index.ts (1 hunks)
  • packages/server/src/api/rpc/index.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: build-test (20.x)
  • GitHub Check: dependency-review
  • GitHub Check: build-test (20.x)
  • GitHub Check: build-test (20.x)
  • GitHub Check: OSSAR-Scan
🔇 Additional comments (6)
packages/schema/src/cli/config.ts (1)

3-3: Switched to zod-validation-error/v3 — approved

Matches the project-wide update. Interpolation of fromZodError(err) in error strings remains compatible with v3.

Use the script posted in another comment to ensure no leftover root imports and dependency presence.

packages/plugins/openapi/src/generator-base.ts (1)

6-6: Import path update is correct

Using fromZodError from v3 for validation error reporting is consistent with the rest of the repo.

packages/runtime/src/enhancements/node/policy/handler.ts (1)

4-4: All zod-validation-error imports now point to /v3
Ran a search for any remaining root imports (import .*zod-validation-error excluding /v3) and found none. Changes are consistent and safe to merge.

packages/server/src/api/rpc/index.ts (1)

13-13: LGTM: versioned subpath import is correct

Importing from 'zod-validation-error/v3' aligns with the package’s versioned entrypoints. No functional changes in this file.

packages/server/src/api/rest/index.ts (2)

19-19: LGTM: import path updated to v3

The change to 'zod-validation-error/v3' matches the intended migration; downstream calls remain compatible.


19-19: Cross-check workspace for stragglers and version compatibility

Ensure all packages import the v3 subpath and the declared dependency range supports it.

Use the same verification script as above from the repo root. Outcomes should show:

  • No root or non-v3 imports remaining.
  • package.json entries resolved to v3-compatible versions.

@ymc9 ymc9 merged commit f889796 into dev Aug 9, 2025
12 checks passed
@ymc9 ymc9 deleted the chore/update-zod-validation-error branch August 9, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants