-
-
Couldn't load subscription status.
- Fork 126
chore: update zod-validation-error #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe changes update the import path for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
packages/runtime/src/enhancements/node/policy/handler.ts (1)
18-18: Import reorder of local helpers is a no-opOnly ordering changed (
invariantfirst). No functional impact.For consistency, ensure import ordering follows the repo’s ESLint/Prettier rules, if any.
packages/runtime/src/enhancements/node/policy/policy-utils.ts (1)
5-5: Updated tozod-validation-error/v3— approvedCompatible with existing usages in logs and error messages.
Optional: standardize on
fromZodError(err).messageacross the codebase for consistency and to avoid relying on implicittoString().
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
packages/plugins/openapi/package.jsonis excluded by!**/*.jsonpackages/runtime/package.jsonis excluded by!**/*.jsonpackages/schema/package.jsonis excluded by!**/*.jsonpackages/server/package.jsonis excluded by!**/*.jsonpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml,!**/*.yamlpnpm-workspace.yamlis excluded by!**/*.yaml
📒 Files selected for processing (7)
packages/plugins/openapi/src/generator-base.ts(1 hunks)packages/runtime/src/enhancements/node/policy/handler.ts(2 hunks)packages/runtime/src/enhancements/node/policy/policy-utils.ts(1 hunks)packages/runtime/src/validation.ts(1 hunks)packages/schema/src/cli/config.ts(1 hunks)packages/server/src/api/rest/index.ts(1 hunks)packages/server/src/api/rpc/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build-test (20.x)
- GitHub Check: dependency-review
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
- GitHub Check: OSSAR-Scan
🔇 Additional comments (6)
packages/schema/src/cli/config.ts (1)
3-3: Switched tozod-validation-error/v3— approvedMatches the project-wide update. Interpolation of
fromZodError(err)in error strings remains compatible with v3.Use the script posted in another comment to ensure no leftover root imports and dependency presence.
packages/plugins/openapi/src/generator-base.ts (1)
6-6: Import path update is correctUsing
fromZodErrorfromv3for validation error reporting is consistent with the rest of the repo.packages/runtime/src/enhancements/node/policy/handler.ts (1)
4-4: Allzod-validation-errorimports now point to/v3
Ran a search for any remaining root imports (import .*zod-validation-errorexcluding/v3) and found none. Changes are consistent and safe to merge.packages/server/src/api/rpc/index.ts (1)
13-13: LGTM: versioned subpath import is correctImporting from 'zod-validation-error/v3' aligns with the package’s versioned entrypoints. No functional changes in this file.
packages/server/src/api/rest/index.ts (2)
19-19: LGTM: import path updated to v3The change to 'zod-validation-error/v3' matches the intended migration; downstream calls remain compatible.
19-19: Cross-check workspace for stragglers and version compatibilityEnsure all packages import the v3 subpath and the declared dependency range supports it.
Use the same verification script as above from the repo root. Outcomes should show:
- No root or non-v3 imports remaining.
- package.json entries resolved to v3-compatible versions.
No description provided.