feat: support for the new "prisma-client" generator

[ymc9]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduce comprehensive support for both legacy and new Prisma client generators across multiple packages. They centralize generator detection logic, add branching to handle new generator behaviors, enforce output requirements for the new generator in CLI actions, and update plugins and tests to accommodate the new Prisma client file structure and import paths. Integration tests for advanced schema features with the new generator are also added.

Changes

Files / Areas	Change Summary
packages/sdk/src/utils.ts	Added getPrismaClientGenerator utility to detect both legacy and new Prisma client generators; updated getPreviewFeatures to recognize new provider.
packages/plugins/tanstack-query/src/generator.ts	Refactored to use getPrismaClientGenerator; added conditional handling and warning for "portable" option with new Prisma client generator.
packages/schema/src/cli/actions/generate.ts	Added validation: new Prisma client generator now requires explicit --output parameter; throws error if missing.
packages/schema/src/cli/plugin-runner.ts	Adjusted project emit/save logic to check for output option; minor formatting changes.
packages/schema/src/plugins/enhancer/enhance/index.ts	Refactored to use getPrismaClientGenerator; added branching for legacy vs. new Prisma client; split type processing methods; updated import path logic.
packages/schema/src/plugins/prisma/index.ts	Unified generator detection with getPrismaClientGenerator; adjusted import path and type declaration resolution for new generator.
packages/schema/src/plugins/prisma/schema-generator.ts	Expanded provider check to include both "prisma-client-js" and "prisma-client".
packages/testtools/src/schema.ts	Reordered Prisma client initialization to occur after TypeScript compilation; logic unchanged.
tests/integration/tests/misc/prisma-client-generator.test.ts	Added new integration tests for Prisma client generator: tests for auth() in @default and delegate models/model inheritance with new generator.
tests/integration/tests/cli/generate.test.ts	Updated CLI generate test to expect TypeScript output files and assert absence of JavaScript files in custom output directory.

Sequence Diagram(s)

sequenceDiagram
    participant CLI
    participant SDK Utils
    participant EnhancerPlugin
    participant PrismaPlugin

    CLI->>SDK Utils: getPrismaClientGenerator(model)
    SDK Utils-->>CLI: { output, provider, isNewGenerator, ... }
    CLI->>CLI: Validate output if isNewGenerator
    CLI->>EnhancerPlugin: runEnhancer(model)
    EnhancerPlugin->>SDK Utils: getPrismaClientGenerator(model)
    SDK Utils-->>EnhancerPlugin: { ... }
    EnhancerPlugin->>EnhancerPlugin: Branch: legacy or new generator
    EnhancerPlugin->>PrismaPlugin: process client types (legacy/new)
    PrismaPlugin->>SDK Utils: getPrismaClientGenerator(model)
    SDK Utils-->>PrismaPlugin: { ... }
    PrismaPlugin->>PrismaPlugin: Adjust import path/type resolution

Loading

Possibly related PRs

• zenstackhq/zenstack#2078: Refactors logical Prisma client exports in the EnhancerGenerator; related through modifications to generator handling logic.
• zenstackhq/zenstack#1850: Modifies Tanstack Query plugin generator to handle the portable option, similar to changes in this PR.
• zenstackhq/zenstack#1721: Adds tests for password hashing in delegate models; related through testing delegate model behavior in Prisma clients.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d526fe and 99c3571.

📒 Files selected for processing (1)

• tests/integration/tests/cli/generate.test.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/integration/tests/cli/generate.test.ts

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: dependency-review
• GitHub Check: OSSAR-Scan
• GitHub Check: build-test (20.x)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: build-test (20.x)
• GitHub Check: build-test (20.x)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ymc9]

fixes #2135 #2093