Skip to content

refactor: correct minor mistakes picked up by coderabbitai in nitpick comments #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 27, 2024
Merged

refactor: correct minor mistakes picked up by coderabbitai in nitpick comments #1887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc072dd
refactor: add optional one to many relationship to model meta
roomman Nov 25, 2024
0f0a66f
refactor: adds guards for fields with null values
roomman Nov 25, 2024
9a31bcb
test: tests for optimistic updates with optional relationships
roomman Nov 25, 2024
ec8121a
Merge branch 'dev' of https://github.com/zenstackhq/zenstack into dev
roomman Nov 26, 2024
4e08271
refactor: addresses some coderabbitai review, nitpick comments
roomman Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/plugins/tanstack-query/tests/react-hooks-v5.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ describe('Tanstack Query React Hooks V5 Test', () => {
expect(userResult.current.data).toHaveLength(1);
});

// pupulate the cache with a category
// populate the cache with a category
const categoryData: any[] = [{ id: '1', name: 'category1', posts: [] }];

nock(BASE_URL)
Expand Down Expand Up @@ -501,7 +501,7 @@ describe('Tanstack Query React Hooks V5 Test', () => {
it('optimistic update with optional one-to-many relationship', async () => {
const { queryClient, wrapper } = createWrapper();

// populate the cache with a post, with an optional category relatonship
// populate the cache with a post, with an optional category relationship
const postData: any = {
id: '1',
title: 'post1',
Expand Down
1 change: 0 additions & 1 deletion packages/plugins/tanstack-query/tests/test-model-meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export const modelMeta: ModelMeta = {
type: 'Category',
name: 'category',
isDataModel: true,
isOptional: true,
isRelationOwner: true,
backLink: 'posts',
foreignKeyMapping: { id: 'categoryId' },
Expand Down
Loading