Skip to content

🐞 fix (server): support for awaiting next.js 15 params #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024
Merged

🐞 fix (server): support for awaiting next.js 15 params #1805

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5ee13d
🐞 fix (server): support for awaiting next.js 15 params
AmruthPillai Oct 24, 2024
224f65f
refactor code to coderabbit's suggestions
AmruthPillai Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/server/src/next/app-route-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { AppRouteRequestHandlerOptions } from '.';
import { RPCApiHandler } from '../api';
import { loadAssets } from '../shared';

type Context = { params: { path: string[] } };
type Context = { params: Promise<{ path: string[] }> };

/**
* Creates a Next.js 13 "app dir" API route request handler which encapsulates Prisma CRUD operations.
Expand All @@ -28,17 +28,18 @@ export default function factory(
}

const url = new URL(req.url);
const params = await context.params;
const query = Object.fromEntries(url.searchParams);

if (!context.params.path) {
if (!params.path) {
return NextResponse.json(
{ message: 'missing path parameter' },
{
status: 400,
}
);
}
const path = context.params.path.join('/');
const path = params.path.join('/');

let requestBody: unknown;
if (req.body) {
Expand Down