Skip to content

fix(openapi): wrong spec for "Meta" object for rpc-style generation #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix(openapi): wrong spec for "Meta" object for rpc-style generation #1673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions packages/plugins/openapi/src/rpc-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,18 +637,13 @@ export class RPCOpenAPIGenerator extends OpenAPIGeneratorBase {

schemas['_Meta'] = {
type: 'object',
description: 'Meta information about the request or response',
properties: {
meta: {
type: 'object',
description: 'Meta information about the request or response',
properties: {
serialization: {
description: 'Serialization metadata',
},
},
additionalProperties: true,
serialization: {
description: 'Serialization metadata',
},
},
additionalProperties: true,
};

schemas['_Error'] = {
Expand Down
11 changes: 4 additions & 7 deletions packages/plugins/openapi/tests/baseline/rpc-3.0.0.baseline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3212,14 +3212,11 @@ components:
nullable: true
_Meta:
type: object
description: Meta information about the request or response
properties:
meta:
type: object
description: Meta information about the request or response
properties:
serialization:
description: Serialization metadata
additionalProperties: true
serialization:
description: Serialization metadata
additionalProperties: true
_Error:
type: object
required:
Expand Down
11 changes: 4 additions & 7 deletions packages/plugins/openapi/tests/baseline/rpc-3.1.0.baseline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3276,14 +3276,11 @@ components:
- type: string
_Meta:
type: object
description: Meta information about the request or response
properties:
meta:
type: object
description: Meta information about the request or response
properties:
serialization:
description: Serialization metadata
additionalProperties: true
serialization:
description: Serialization metadata
additionalProperties: true
_Error:
type: object
required:
Expand Down
11 changes: 4 additions & 7 deletions packages/plugins/openapi/tests/baseline/rpc-type-coverage-3.0.0.baseline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1861,14 +1861,11 @@ components:
nullable: true
_Meta:
type: object
description: Meta information about the request or response
properties:
meta:
type: object
description: Meta information about the request or response
properties:
serialization:
description: Serialization metadata
additionalProperties: true
serialization:
description: Serialization metadata
additionalProperties: true
_Error:
type: object
required:
Expand Down
11 changes: 4 additions & 7 deletions packages/plugins/openapi/tests/baseline/rpc-type-coverage-3.1.0.baseline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1903,14 +1903,11 @@ components:
format: byte
_Meta:
type: object
description: Meta information about the request or response
properties:
meta:
type: object
description: Meta information about the request or response
properties:
serialization:
description: Serialization metadata
additionalProperties: true
serialization:
description: Serialization metadata
additionalProperties: true
_Error:
type: object
required:
Expand Down