fix: check attribute function shouldn't delegate "postUpdate" rules

[ymc9]

Fixes #1642

[coderabbitai]

Walkthrough

Walkthrough

The changes include a modification to the ExpressionWriter class to handle the postUpdate operation by returning a constant value instead of invoking a guard function. Additionally, a new regression test file is introduced to validate access policies for the User and Post models, ensuring proper enforcement of access controls based on user permissions.

Changes

Files	Change Summary
packages/schema/src/plugins/enhancer/policy/expression-writer.ts	Updated postUpdate operation logic to return false instead of invoking the guard function.
tests/regression/tests/issue-1642.test.ts	Introduced a regression test for issue 1642, validating access policies for User and Post models.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure postUpdate operation does not delegate to relations (1642)	✅
Validate access policies for User and Post models (1642)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8589b79 and c9a4e5a.

Files selected for processing (2)

• packages/schema/src/plugins/enhancer/policy/expression-writer.ts (1 hunks)
• tests/regression/tests/issue-1642.test.ts (1 hunks)

Additional comments not posted (6)

tests/regression/tests/issue-1642.test.ts (5)

1-1: LGTM!

The import statement is correct and necessary for the test setup.

---

2-2: LGTM!

The describe block is correctly defining the test suite.

---

3-3: LGTM!

The it block is correctly defining the test case.

---

4-28: LGTM!

The test setup and schema definition are correct and necessary for the regression test.

---

29-39: LGTM!

The test execution and assertions are correct and necessary to validate the regression.

packages/schema/src/plugins/enhancer/policy/expression-writer.ts (1)

818-826: LGTM! But verify the function usage in the codebase.

The changes are correctly handling the postUpdate operation by explicitly defining the behavior. Ensure that all function calls to writeRelationCheck are updated accordingly.

Run the following script to verify the function usage:

Verification successful

---

Verification Successful: writeRelationCheck Usage is Consistent with New Logic

The writeRelationCheck function is used correctly within the codebase, and its logic for handling the postUpdate operation is properly integrated. No further updates are necessary.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `writeRelationCheck` match the new logic.

# Test: Search for the function usage. Expect: Only occurrences of the new logic.
rg --type ts -A 5 $'writeRelationCheck'

Length of output: 1421

---

Script:

#!/bin/bash
# Description: Gather more context around the usage of `writeRelationCheck` in the codebase.

# Search for the function definition and its usage with more surrounding lines for context.
rg --type ts -A 10 -B 10 'writeRelationCheck'

Length of output: 4326