fix(delegate): delegate models returned in nested results don't include base fields #1662
Conversation
…de base fields Fixes #1645
WalkthroughWalkthroughThe changes include significant updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
participant Database
User->>System: Create Order
System->>Database: Update Order with Billing and Shipping Address
Database-->>System: Return updated Order with Addresses
System-->>User: Display Order Details
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
packages/runtime/src/enhancements/delegate.ts (1)
Line range hint
1143-1147: Consider using a more specific type instead ofany.The
assembleHierarchymethod is correctly implemented, but the use ofanyshould be reconsidered for better type safety.Consider using a more specific type for the
resultvariable to improve type safety.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/runtime/src/enhancements/delegate.ts (3 hunks)
- tests/regression/tests/issue-1645.test.ts (1 hunks)
Additional comments not posted (14)
tests/regression/tests/issue-1645.test.ts (10)
1-1: LGTM!The import statement is correct and necessary for the test.
The code changes are approved.
2-2: LGTM!The
describeblock is correctly used to group related tests.The code changes are approved.
3-3: LGTM!The
itblock is correctly used to define the test case.The code changes are approved.
4-137: LGTM!The schema definitions are comprehensive and cover the necessary models for the test.
The code changes are approved.
138-139: LGTM!The
enhancefunction is correctly used to enhance the database client.The code changes are approved.
141-141: LGTM!The user creation is correctly implemented.
The code changes are approved.
143-157: LGTM!The shipping address creation is correctly implemented.
The code changes are approved.
159-173: LGTM!The billing address creation is correctly implemented.
The code changes are approved.
175-185: LGTM!The order creation is correctly implemented.
The code changes are approved.
187-202: LGTM!The order update and assertions are correctly implemented.
The code changes are approved.
packages/runtime/src/enhancements/delegate.ts (4)
Line range hint
1-15: LGTM!The import statements are correct and necessary for the functionality.
The code changes are approved.
Line range hint
22-27: LGTM!The constructor is correctly implemented.
The code changes are approved.
Line range hint
54-92: LGTM!The
doFindmethod is correctly implemented.The code changes are approved.
155-167: LGTM!The
injectSelectIncludeHierarchymethod is correctly implemented.The code changes are approved.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/runtime/src/enhancements/delegate.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/runtime/src/enhancements/delegate.ts
Fixes #1645