Skip to content

feat(redwood): redwood v7 support #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2024
Merged

feat(redwood): redwood v7 support #1617

merged 2 commits into from
Jul 28, 2024

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Jul 27, 2024

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 27, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent updates enhance compatibility with various versions of RedwoodJS by refining the installGraphQLPlugin function to utilize version-specific logic for module imports. This ensures smoother integration with different Redwood versions. Additionally, the introduction of Prisma types across multiple files enhances type safety and accessibility for developers, particularly benefiting those using ZenStack in RedwoodJS projects.

Changes

File Path Change Summary
packages/misc/redwood/src/commands/setup.ts Modified installGraphQLPlugin to include version checks for module declarations, ensuring compatibility with Redwood versions below and above 7.0.0.
packages/runtime/res/enhance.d.ts Expanded exports to include type PrismaClient, enhancing the module's public API for improved type safety.
packages/schema/src/plugins/enhancer/enhance/index.ts Updated import/export statements to include PrismaClient, improving type accessibility throughout the module.

Possibly related issues

  • Redwood package for RedwoodJS V7 #1553: The changes directly address the ZenStack integration with RedwoodJS V7 by updating module declarations, aligning with the issue's context regarding compatibility following the Redwood migration.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 27, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5b437d9 and 57af81d.

Files ignored due to path filters (2)
  • packages/misc/redwood/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
Files selected for processing (3)
  • packages/misc/redwood/src/commands/setup.ts (2 hunks)
  • packages/runtime/res/enhance.d.ts (1 hunks)
  • packages/schema/src/plugins/enhancer/enhance/index.ts (2 hunks)
Additional comments not posted (5)
packages/runtime/res/enhance.d.ts (1)

1-1: LGTM!

The addition of type PrismaClient to the export statement enhances type safety and accessibility.

packages/misc/redwood/src/commands/setup.ts (2)

1-1: LGTM!

The new imports for getInstalledRedwoodVersion and semver are necessary for version checking of the Redwood framework.

Also applies to: 7-7

148-153: LGTM!

The conditional logic for determining the module to declare based on the installed version of Redwood ensures compatibility with different versions.

packages/schema/src/plugins/enhancer/enhance/index.ts (2)

130-132: LGTM!

The changes to createSimplePrismaImports enhance type accessibility and safety by importing and exporting PrismaClient.

156-156: LGTM!

The changes to createLogicalPrismaImports enhance type accessibility and safety by importing and exporting PrismaClient.

@ymc9
Copy link
Member Author

ymc9 commented Jul 27, 2024

Fixes #1553

coderabbitai[bot]
coderabbitai bot reviewed Jul 27, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 57af81d and 6d96425.

Files selected for processing (1)
  • packages/misc/redwood/src/commands/setup.ts (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/misc/redwood/src/commands/setup.ts

@ymc9 ymc9 merged commit 3831350 into dev Jul 28, 2024
@ymc9 ymc9 deleted the feat/rw-v7-support branch July 28, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ymc9