Type inference lost when enhancing a client with prisma extensions

[genu]

DynamicClientExtensionThis

Thanks for making the fix @genu ! These types can indeed be imported directly from "@prisma/client/runtime/library" instead. The code changes look good to me, and I'll make some minor tweaks and add a test then merge.

Thank you!

@ymc9 From my observation, this partly resolved the issue.

type inference is lost when using prisma extensions:

const prisma = new PrismaClient()
const db = enhance(prisma)

db.user.find() // <-- db.user is properly typed

With Enhanced client:

const prisma = new PrismaClient().$extends({})

const db = enhance(prisma)

db.user.find() // <-- db.user is any

Originally posted by @genu in #2171 (comment)

[marekryb]

I am unable to upgrade zenstack to 2.16.1 because of this issue. And I am NOT using the new prisma-client generator. Seems #2171 introduced a regression for anyone using prisma extensions.

error TS18046: 'prisma.storage' is of type 'unknown'.

56     const storage = await prisma.storage.findUniqueOrThrow({

error TS18046: 'prisma.document' is of type 'unknown'.

73       const docs = await prisma.document.findMany({

...and many more

[ymc9]

Thanks guys, I'll look into it.

[ymc9]

I wasn't able to reproduce it with this project: https://github.com/ymc9/prisma-new-generator

Do you guys have a shareable repro? @genu @marekryb

[marekryb]

@ymc9 Here you go: https://github.com/marekryb/zenstack-issue-2175

Thank you for looking into this.

Sidenotes:

1. I am using prisma-client-js generator here, but with new one it seems the same.
2. I am using pnpm as package manager so I define all output path in zmodel and then import them directly to avoid various node_modules problems. Not sure it makes any difference, but it might.
3. tsconfig also seems to have some effect - this one is from nestjs app.

[ymc9]

@ymc9 Here you go: https://github.com/marekryb/zenstack-issue-2175

Thank you for looking into this.

Sidenotes:

1. I am using prisma-client-js generator here, but with new one it seems the same.
2. I am using pnpm as package manager so I define all output path in zmodel and then import them directly to avoid various node_modules problems. Not sure it makes any difference, but it might.
3. tsconfig also seems to have some effect - this one is from nestjs app.

Thanks!

I'm able to reproduce the issue. There was a change of the import path for DynamicClientExtensionThis type (used for prisma client extensions), however the contents of the two copies of this type definition are exactly the same. I'm still trying to figure out why typescript is happy with one but not the other ...

[ymc9]

I'm making the change to at least revert the import method for the old "prisma-client-js" generator. Will publish a patch release soon.

[ymc9]

Fixed in 2.17.0