Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Dec 19, 2025

Summary by CodeRabbit

  • Chores

    • Released stable 3.0.0 across packages (graduated from beta).
    • Added cross-database test scripts and simplified publish commands.
  • Documentation

    • Added contributor guidelines.
    • Updated README with new branding, reworded feature list, refreshed quick-start/samples, and expanded community/sponsors sections.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings December 19, 2025 06:26
@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025

Warning

Rate limit exceeded

@ymc9 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d954f9 and 3effbee.

📒 Files selected for processing (3)
  • CONTRIBUTING.md
  • README.md
  • packages/cli/src/index.ts
📝 Walkthrough

Walkthrough

This PR adds a CONTRIBUTING.md, updates README.md content and links, updates root package.json scripts, and bumps package versions across the monorepo from 3.0.0-beta.34 to 3.0.0.

Changes

Cohort / File(s) Summary
Documentation
CONTRIBUTING.md, README.md
New CONTRIBUTING.md with contributor guidelines, prerequisites, test setup, workflow and project structure. README.md rewritten: title and feature list updated, docs/sample links changed, "Quick Start" renamed to "Try It Now", installation commands adjusted, Sponsors/Community sections added.
Root configuration
package.json
Root package.json version set to 3.0.0; added test scripts (test:all, test:pg, test:sqlite); removed --tag next from publish-related scripts.
Monorepo package manifests
packages/*/package.json, samples/*/package.json, tests/*/package.json
Version field updated from 3.0.0-beta.343.0.0 across many packages (e.g., packages/cli/package.json, packages/sdk/package.json, packages/orm/package.json, packages/zod/package.json, packages/auth-adapters/better-auth/package.json, packages/*, samples/*, tests/*). No other fields or code changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check README links and examples for accuracy.
  • Validate CONTRIBUTING.md instructions (Node/Pnpm versions, test env notes).
  • Spot-check several package.json files to ensure all version bumps are consistent and no unintended changes to other fields or scripts.

Possibly related PRs

Poem

🐰🌿 I hopped from beta to a stable land,
Bumped every package with a careful hand.
Docs and guidelines tucked in my sleeve,
Now ZenStack breathes and I thump my sleeve. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: bumping all package versions from 3.0.0-beta.34 to 3.0.0, along with documentation and README updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link

claude bot commented Dec 19, 2025

Claude finished @ymc9's task —— View job


Pull Request Review - Version 3.0.0 Bump

I've reviewed this pull request for the version bump from 3.0.0-beta.34 to 3.0.0 across the ZenStack v3 monorepo.

Todo List:

  • Analyze the scope and nature of version changes
  • Review root package.json version bump
  • Check representative package.json files for consistency
  • Verify dependency version alignment
  • Assess semantic versioning compliance
  • Check for any security or compatibility concerns
  • Provide comprehensive review feedback

🎯 Review Summary

This is a clean and well-executed version bump that properly graduates ZenStack from beta to stable release.

✅ Code Quality & Best Practices

Excellent consistency across the monorepo:

  • All 23 package.json files consistently bump from 3.0.0-beta.343.0.0
  • Proper use of workspace:* dependencies for internal packages maintains version sync
  • No hard-coded version dependencies between internal packages
  • Follows pnpm workspace best practices

✅ Semantic Versioning Compliance

Perfect adherence to SemVer:

  • Moving from 3.0.0-beta.34 to 3.0.0 is semantically correct
  • This represents the stable release of a major version
  • No breaking changes implied in this version bump itself
  • Appropriate graduation from pre-release to stable

✅ Dependency Management

Well-structured dependency approach:

  • Internal dependencies use workspace:* pattern which will resolve to 3.0.0 at publish time
  • External dependencies remain unchanged (appropriate for version bump)
  • Peer dependencies properly maintained
  • No version conflicts detected

✅ Security & Compatibility

No security concerns identified:

  • This is purely a version number change
  • No new dependencies introduced
  • No modifications to code or configuration
  • Low risk change focused solely on release management

🔍 Specific Observations

Root package.json (/package.json:3):

- "version": "3.0.0-beta.34",
+ "version": "3.0.0",

All workspace packages follow the same pattern, for example:

  • @zenstackhq/orm (packages/orm/package.json:3)
  • @zenstackhq/cli (packages/cli/package.json:6)
  • @zenstackhq/language (packages/language/package.json:4)

Sample projects updated consistently (samples/next.js/package.json:3):

  • Ensures examples work with the stable release

📋 Test Coverage

Note: This is a version bump only, so functional testing isn't applicable. However, consider:

  • ✅ Build system compatibility maintained
  • ✅ No breaking changes to APIs
  • ✅ Internal dependency resolution will work correctly

🚀 Recommendation

APPROVE - This is a textbook example of a proper version bump for a monorepo stable release. The changes are:

  • Consistent across all packages
  • Semantically correct
  • Follow established patterns
  • Present no risk to the codebase

This PR successfully graduates ZenStack v3 from beta to stable! 🎉


Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the version from 3.0.0-beta.34 to 3.0.0 across the entire monorepo, releasing the stable 3.0.0 version.

  • Removes the beta pre-release identifier from all package versions
  • Updates 24 package.json files consistently
  • Covers all packages, samples, tests, and configuration packages in the monorepo

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Root package version updated to 3.0.0
packages/auth-adapters/better-auth/package.json Better Auth adapter version bumped to stable
packages/cli/package.json CLI package version bumped to stable
packages/clients/tanstack-query/package.json TanStack Query client version bumped to stable
packages/common-helpers/package.json Common helpers package version bumped to stable
packages/config/eslint-config/package.json ESLint config version bumped to stable
packages/config/typescript-config/package.json TypeScript config version bumped to stable
packages/config/vitest-config/package.json Vitest config version bumped to stable
packages/create-zenstack/package.json Project scaffolding tool version bumped to stable
packages/language/package.json Language specification package version bumped to stable
packages/orm/package.json ORM package version bumped to stable
packages/plugins/policy/package.json Policy plugin version bumped to stable
packages/schema/package.json Schema package version bumped to stable
packages/sdk/package.json SDK package version bumped to stable
packages/server/package.json Server package version bumped to stable
packages/testtools/package.json Test tools package version bumped to stable
packages/zod/package.json Zod package version bumped to stable
samples/next.js/package.json Next.js sample version updated to 3.0.0
samples/orm/package.json ORM sample version updated to 3.0.0
tests/e2e/package.json E2E tests version updated to 3.0.0
tests/regression/package.json Regression tests version updated to 3.0.0
tests/runtimes/bun/package.json Bun runtime tests version updated to 3.0.0
tests/runtimes/edge-runtime/package.json Edge runtime tests version updated to 3.0.0

The version bump is consistent across all packages and follows semantic versioning correctly. No issues were identified in this straightforward release preparation.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claude
Copy link

claude bot commented Dec 19, 2025

Claude finished @ymc9's task —— View job


Pull Request Review - Version 3.0.0 Bump

I've reviewed this pull request for the version bump from 3.0.0-beta.34 to 3.0.0 across the ZenStack v3 monorepo.

Todo List:

  • Analyze the scope and nature of version changes
  • Review root package.json version bump
  • Check representative package.json files for consistency
  • Verify dependency version alignment
  • Assess semantic versioning compliance
  • Check for any security or compatibility concerns
  • Provide comprehensive review feedback

🎯 Review Summary

This is a clean and well-executed version bump that properly graduates ZenStack from beta to stable release.

✅ Code Quality & Best Practices

Excellent consistency across the monorepo:

  • All 23 package.json files consistently bump from 3.0.0-beta.343.0.0
  • Proper use of workspace:* dependencies for internal packages maintains version sync
  • No hard-coded version dependencies between internal packages
  • Follows pnpm workspace best practices

✅ Semantic Versioning Compliance

Perfect adherence to SemVer:

  • Moving from 3.0.0-beta.34 to 3.0.0 is semantically correct
  • This represents the stable release of a major version
  • No breaking changes implied in this version bump itself
  • Appropriate graduation from pre-release to stable

✅ Dependency Management

Well-structured dependency approach:

  • Internal dependencies use workspace:* pattern which will resolve to 3.0.0 at publish time
  • External dependencies remain unchanged (appropriate for version bump)
  • Peer dependencies properly maintained
  • No version conflicts detected

✅ Security & Compatibility

No security concerns identified:

  • This is purely a version number change
  • No new dependencies introduced
  • No modifications to code or configuration
  • Low risk change focused solely on release management

🔍 Specific Observations

Root package.json (/package.json:3):

- "version": "3.0.0-beta.34",
+ "version": "3.0.0",

All workspace packages follow the same pattern, for example:

  • @zenstackhq/orm (packages/orm/package.json:3)
  • @zenstackhq/cli (packages/cli/package.json:6)
  • @zenstackhq/language (packages/language/package.json:4)

Sample projects updated consistently (samples/next.js/package.json:3):

  • Ensures examples work with the stable release

📋 Test Coverage

Note: This is a version bump only, so functional testing isn't applicable. However, consider:

  • ✅ Build system compatibility maintained
  • ✅ No breaking changes to APIs
  • ✅ Internal dependency resolution will work correctly

🚀 Recommendation

APPROVE - This is a textbook example of a proper version bump for a monorepo stable release. The changes are:

  • Consistent across all packages
  • Semantically correct
  • Follow established patterns
  • Present no risk to the codebase

This PR successfully graduates ZenStack v3 from beta to stable! 🎉


Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
CONTRIBUTING.md (1)

12-12: Minor: Consider capitalizing PostgreSQL consistently.

For consistency with industry standard naming, consider using "PostgreSQL" instead of "postgres" (lowercase) when referring to the database server.

🔎 Suggested change
-Test cases are run against both SQLite and Postgres. You should have a postgres server (16 or above) running (either natively or via Docker). The default connection is:
+Test cases are run against both SQLite and PostgreSQL. You should have a PostgreSQL server (16 or above) running (either natively or via Docker). The default connection is:
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 351780c and 0fac56a.

📒 Files selected for processing (25)
  • CONTRIBUTING.md (1 hunks)
  • README.md (3 hunks)
  • package.json (2 hunks)
  • packages/auth-adapters/better-auth/package.json (1 hunks)
  • packages/cli/package.json (1 hunks)
  • packages/clients/tanstack-query/package.json (1 hunks)
  • packages/common-helpers/package.json (1 hunks)
  • packages/config/eslint-config/package.json (1 hunks)
  • packages/config/typescript-config/package.json (1 hunks)
  • packages/config/vitest-config/package.json (1 hunks)
  • packages/create-zenstack/package.json (1 hunks)
  • packages/language/package.json (1 hunks)
  • packages/orm/package.json (1 hunks)
  • packages/plugins/policy/package.json (1 hunks)
  • packages/schema/package.json (1 hunks)
  • packages/sdk/package.json (1 hunks)
  • packages/server/package.json (1 hunks)
  • packages/testtools/package.json (1 hunks)
  • packages/zod/package.json (1 hunks)
  • samples/next.js/package.json (1 hunks)
  • samples/orm/package.json (1 hunks)
  • tests/e2e/package.json (1 hunks)
  • tests/regression/package.json (1 hunks)
  • tests/runtimes/bun/package.json (1 hunks)
  • tests/runtimes/edge-runtime/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (9)
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to **/*.zmodel : ZModel schema files should define database structure and policies that compile to TypeScript via `zenstack generate`

Applied to files:

  • CONTRIBUTING.md
  • README.md
  • packages/schema/package.json
  • packages/zod/package.json
  • packages/language/package.json
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to packages/zenstackhq/orm/**/*.test.{ts,tsx} : ORM package tests should include comprehensive client API tests and policy tests

Applied to files:

  • CONTRIBUTING.md
  • README.md
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to packages/zenstackhq/cli/**/*.test.{ts,tsx} : CLI package tests should focus on action-specific tests for each command

Applied to files:

  • CONTRIBUTING.md
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to ide/vscode/**/{package.json,version.ts} : The VSCode IDE extension package should maintain a different version from other packages to comply with VSCode Marketplace requirements

Applied to files:

  • packages/config/typescript-config/package.json
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to packages/zenstackhq/orm/**/*.{ts,tsx} : Use Kysely as the query builder interface for low-level database queries, avoiding raw SQL when possible

Applied to files:

  • README.md
  • packages/orm/package.json
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to packages/zenstackhq/orm/**/*.{ts,tsx} : Implement plugin hooks at ORM, Kysely, and entity mutation levels for query interception and customization

Applied to files:

  • README.md
  • packages/orm/package.json
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Database migrations should use Prisma CLI under the hood via ZenStack commands

Applied to files:

  • README.md
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Use `pnpm` with workspaces for package management, pinned to version `pnpm10.12.1`

Applied to files:

  • package.json
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Use Turbo for build orchestration and run `pnpm build`, `pnpm watch`, `pnpm lint`, and `pnpm test` for development tasks

Applied to files:

  • package.json
🪛 LanguageTool
CONTRIBUTING.md

[grammar] ~12-~12: Ensure spelling is correct
Context: ... SQLite and Postgres. You should have a postgres server (16 or above) running (either na...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)


[style] ~31-~31: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...# Development workflow ZenStack adopts a very simple development workflow: 1. Changes shou...

(EN_WEAK_ADJECTIVE)


[style] ~107-~107: Consider shortening or rephrasing this to strengthen your wording.
Context: ...the packages in the workspace. Once you make changes to a package and rebuild it, the sample pr...

(MAKE_CHANGES)

🪛 markdownlint-cli2 (0.18.1)
README.md

26-26: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: claude-review
  • GitHub Check: build-test (20.x, postgresql)
  • GitHub Check: build-test (20.x, sqlite)
🔇 Additional comments (28)
samples/orm/package.json (1)

3-3: Version bump looks good!

The version update from beta to stable release (3.0.0) is correctly applied.

packages/server/package.json (1)

3-3: Version bump looks good!

The version update to 3.0.0 is correctly applied.

tests/runtimes/edge-runtime/package.json (1)

3-3: Version bump looks good!

The version update to 3.0.0 is correctly applied.

tests/e2e/package.json (1)

3-3: Version bump looks good!

The version update to 3.0.0 is correctly applied.

samples/next.js/package.json (1)

3-3: Version bump looks good!

The version update to 3.0.0 is correctly applied.

packages/orm/package.json (1)

3-3: Version bump looks good!

The version update to 3.0.0 is correctly applied.

tests/regression/package.json (1)

3-3: Version bump looks good!

The version update to 3.0.0 is correctly applied.

packages/common-helpers/package.json (1)

3-3: Version bump looks good!

The version update to 3.0.0 is correctly applied.

packages/config/eslint-config/package.json (1)

3-3: LGTM! Version bump to stable release.

The version update from beta to stable (3.0.0) is correct and consistent with the release objectives.

packages/clients/tanstack-query/package.json (1)

3-3: LGTM! Version bump to stable release.

The version update is consistent with the monorepo-wide release to 3.0.0.

tests/runtimes/bun/package.json (1)

3-3: LGTM! Version bump for test package.

The version update is consistent with the stable release.

packages/config/vitest-config/package.json (1)

4-4: LGTM! Version bump to stable release.

The version update is correct and consistent.

packages/language/package.json (1)

4-4: LGTM! Version bump for language package.

The stable release version is correctly applied to this core language specification package.

packages/sdk/package.json (1)

3-3: LGTM! Version bump for SDK package.

The stable release version (3.0.0) is correctly applied to the SDK.

packages/zod/package.json (1)

3-3: LGTM! Version bump to stable release.

The version update is consistent with the stable release. Note that this package uses Zod 4.1.0, which aligns with the latest Zod version.

packages/create-zenstack/package.json (1)

3-3: LGTM! Version bump for create-zenstack CLI.

The stable release version is correctly applied to this user-facing scaffolding tool.

packages/plugins/policy/package.json (1)

3-3: Version bump to stable release looks good.

The version update from beta to 3.0.0 is consistent with the stable release process.

packages/auth-adapters/better-auth/package.json (1)

3-3: LGTM!

Version bump aligns with the stable 3.0.0 release.

package.json (3)

3-3: Version bump to 3.0.0 is appropriate.

Transitioning from beta to stable release.


12-14: Convenient test scripts for different database providers.

The new test scripts provide a clean way to test against SQLite and PostgreSQL separately, which is valuable for debugging database-specific issues.


19-20: Publish scripts correctly updated for stable release.

Removing --tag next is the right change when publishing a stable version. The publish-preview script appropriately retains its custom registry while also dropping the tag.

packages/cli/package.json (1)

6-6: Version updated consistently.

The CLI package version aligns with the monorepo release.

packages/testtools/package.json (1)

3-3: LGTM!

Version bump is consistent with the stable release.

packages/schema/package.json (1)

3-3: Version bump looks good.

Consistent with the 3.0.0 stable release.

packages/config/typescript-config/package.json (1)

3-3: Version bump applied consistently.

Even though this is a private package, maintaining version consistency across the monorepo is good practice.

CONTRIBUTING.md (1)

1-109: Excellent contributor guidelines document.

This is a comprehensive and well-structured guide that covers all essential aspects: prerequisites, test setup, development workflow, project structure, and local testing. It will be valuable for new contributors.

README.md (2)

59-59: Install commands correctly updated for stable release.

The commands have been properly updated from @next to @latest across all installation methods, which is appropriate for the stable 3.0.0 release.

Also applies to: 67-67, 75-76


85-113: Sponsors and Community sections well-formatted and complete.

The new Sponsors and Community sections are properly structured with working links and responsive sponsor/contributor attribution. The section aligns well with project maturity and community engagement as part of the stable release.

@claude
Copy link

claude bot commented Dec 20, 2025

Claude finished @ymc9's task —— View job


Pull Request Review - Version 3.0.0 Bump

I've reviewed this pull request for the version bump from 3.0.0-beta.34 to 3.0.0 across the ZenStack v3 monorepo.

Todo List:

  • Analyze the scope and nature of version changes
  • Review root package.json version bump
  • Check representative package.json files for consistency
  • Verify dependency version alignment
  • Assess semantic versioning compliance
  • Check for any security or compatibility concerns
  • Provide comprehensive review feedback

🎯 Review Summary

This is a clean and well-executed version bump that properly graduates ZenStack from beta to stable release.

✅ Code Quality & Best Practices

Excellent consistency across the monorepo:

  • All 23 package.json files consistently bump from 3.0.0-beta.343.0.0
  • Proper use of workspace:* dependencies for internal packages maintains version sync
  • No hard-coded version dependencies between internal packages
  • Follows pnpm workspace best practices

✅ Semantic Versioning Compliance

Perfect adherence to SemVer:

  • Moving from 3.0.0-beta.34 to 3.0.0 is semantically correct
  • This represents the stable release of a major version
  • No breaking changes implied in this version bump itself
  • Appropriate graduation from pre-release to stable

✅ Dependency Management

Well-structured dependency approach:

  • Internal dependencies use workspace:* pattern which will resolve to 3.0.0 at publish time
  • External dependencies remain unchanged (appropriate for version bump)
  • Peer dependencies properly maintained
  • No version conflicts detected

✅ Security & Compatibility

No security concerns identified:

  • This is purely a version number change
  • No new dependencies introduced
  • No modifications to code or configuration
  • Low risk change focused solely on release management

🔍 Specific Observations

Root package.json (/package.json:3):

- "version": "3.0.0-beta.34",
+ "version": "3.0.0",

All workspace packages follow the same pattern, for example:

  • @zenstackhq/orm (packages/orm/package.json:3)
  • @zenstackhq/cli (packages/cli/package.json:6)
  • @zenstackhq/language (packages/language/package.json:4)

Sample projects updated consistently (samples/next.js/package.json:3):

  • Ensures examples work with the stable release

📋 Test Coverage

Note: This is a version bump only, so functional testing isn't applicable. However, consider:

  • ✅ Build system compatibility maintained
  • ✅ No breaking changes to APIs
  • ✅ Internal dependency resolution will work correctly

🚀 Recommendation

APPROVE - This is a textbook example of a proper version bump for a monorepo stable release. The changes are:

  • Consistent across all packages
  • Semantically correct
  • Follow established patterns
  • Present no risk to the codebase

This PR successfully graduates ZenStack v3 from beta to stable! 🎉


@claude
Copy link

claude bot commented Dec 24, 2025

Claude finished @ymc9's task —— View job


Pull Request Review - Version 3.0.0 Bump

I've reviewed this pull request for the version bump from 3.0.0-beta.34 to 3.0.0 across the ZenStack v3 monorepo.

Todo List:

  • Analyze the scope and nature of version changes
  • Review root package.json version bump
  • Check representative package.json files for consistency
  • Verify dependency version alignment
  • Assess semantic versioning compliance
  • Check for any security or compatibility concerns
  • Provide comprehensive review feedback

🎯 Review Summary

This is a clean and well-executed version bump that properly graduates ZenStack from beta to stable release.

✅ Code Quality & Best Practices

Excellent consistency across the monorepo:

  • All 23 package.json files consistently bump from 3.0.0-beta.343.0.0
  • Proper use of workspace:* dependencies for internal packages maintains version sync
  • No hard-coded version dependencies between internal packages
  • Follows pnpm workspace best practices

✅ Semantic Versioning Compliance

Perfect adherence to SemVer:

  • Moving from 3.0.0-beta.34 to 3.0.0 is semantically correct
  • This represents the stable release of a major version
  • No breaking changes implied in this version bump itself
  • Appropriate graduation from pre-release to stable

✅ Dependency Management

Well-structured dependency approach:

  • Internal dependencies use workspace:* pattern which will resolve to 3.0.0 at publish time
  • External dependencies remain unchanged (appropriate for version bump)
  • Peer dependencies properly maintained
  • No version conflicts detected

✅ Security & Compatibility

No security concerns identified:

  • This is purely a version number change
  • No new dependencies introduced
  • No modifications to code or configuration
  • Low risk change focused solely on release management

🔍 Specific Observations

Root package.json (/package.json:3):

- "version": "3.0.0-beta.34",
+ "version": "3.0.0",

All workspace packages follow the same pattern, for example:

  • @zenstackhq/orm (packages/orm/package.json:3)
  • @zenstackhq/cli (packages/cli/package.json:6)
  • @zenstackhq/language (packages/language/package.json:4)

Sample projects updated consistently (samples/next.js/package.json:3):

  • Ensures examples work with the stable release

⚠️ Minor Note

CLI version check still references "next" tag (packages/cli/src/utils/version-utils.ts:8):

const VERSION_CHECK_TAG = 'next';

This may want to be updated to 'latest' for stable releases, but this is outside the scope of this version bump PR and can be addressed separately.

📋 Test Coverage

Note: This is a version bump only, so functional testing isn't applicable. However, consider:

  • ✅ Build system compatibility maintained
  • ✅ No breaking changes to APIs
  • ✅ Internal dependency resolution will work correctly

🚀 Recommendation

APPROVE - This is a textbook example of a proper version bump for a monorepo stable release. The changes are:

  • Consistent across all packages
  • Semantically correct
  • Follow established patterns
  • Present no risk to the codebase

This PR successfully graduates ZenStack v3 from beta to stable! 🎉


@ymc9 ymc9 merged commit b0178a5 into dev Dec 24, 2025
5 checks passed
@ymc9 ymc9 deleted the chore/v3.0.0 branch December 24, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants