Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: This is not intended to be a functional pull request, instead we needed to make this change for our purposes to support arcs in certain conditions. We thought creating the pull request would be helpful to see for maintainers to see the changes.
Context: We're using
react-konva
as our canvas engine when generating SVGs.There seem to be two issues:
x
andy
parameters wereNaN
in some cases. Usingx || 0
seemed to be a reasonable hot-fix for us. It may be that this is areact-konva
specific issue and other applications wouldn't be passingNaN
as a translate argument, but this still might be worth adding anyway since the browser throws an error withNaN
.Context.prototype.translate
, but not as clear. We were able to address theNaN
by adding blanket default fallback value of|| 0
to most of the arguments.