rpc: avoid use of cgo by hard-coding maxPathSize #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has anyone resynced from scratch using this PR? It shouldn't affect syncing, but I'm going to do it anyway. |
sumamu
reviewed
Mar 11, 2024
| if len(endpoint) > int(max_path_size) { | ||
| log.Warn(fmt.Sprintf("The ipc endpoint is longer than %d characters. ", max_path_size), | ||
| // account for null-terminator too | ||
| if len(endpoint)+1 > maxPathSize { |
There was a problem hiding this comment.
Why did you replace it with len(endpoint)+1? The value of maxPathSize stayed the same (108).
There was a problem hiding this comment.
Check the comment above this line
There was a problem hiding this comment.
I have not tested this but can if you think it will be helpful.
0x3639
requested review from
MoonBaZZe and
sumamu
and removed request for
MoonBaZZe
sumamu
approved these changes
Mar 20, 2024
| const ( | ||
| // On Linux, sun_path is 108 bytes in size | ||
| // see http://man7.org/linux/man-pages/man7/unix.7.html | ||
| maxPathSize = int(108) |
There was a problem hiding this comment.
Why int(108) and not just 108?
There was a problem hiding this comment.
@sumamu did you resolve this question?
|
These changes are consistent with this discussion here: ethereum/go-ethereum#27447 (comment) |
0x3639
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented ethereum/go-ethereum#27447