Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getting git version into native build #35

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

georgezgeorgez
Copy link
Collaborator

https://stackoverflow.com/questions/71642366/how-do-you-read-debug-vcs-version-info-from-a-go-1-18-binary

Notably, that go commands are meant to run on package not file argument

@0x3639
Copy link
Collaborator

0x3639 commented Sep 30, 2023

Notes from my review: The PR improves the way the git commit hash is retrieved and used in the build process. Instead of writing the commit hash to a file during the build process (using make version), the commit hash is now retrieved natively using Go's runtime/debug package. This approach is more dynamic and avoids the need to modify a Go file every time a new commit is made.

@georgezgeorgez georgezgeorgez merged commit 9eaedfa into master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants