Skip to content

Ability to stop pipelines early #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

bcdurak
Copy link
Contributor

@bcdurak bcdurak commented May 28, 2025

This PR introduces comprehensive pipeline stopping functionality to ZenML, with particular focus on the Kubernetes orchestrator implementation. The feature enables users to gracefully or forcefully terminate running pipeline executions through both CLI and programmatic interfaces.

Core Changes

Pipeline Run Stop Interface

  • Added stop_run() method to PipelineRunResponse model that delegates to the orchestrator's stop implementation
  • Extended ExecutionStatus enum with STOPPING and STOPPED states to track termination lifecycle
  • Implemented server-side REST API endpoint /runs/{run_id}/stop with graceful termination option
  • Added CLI command zenml pipeline runs stop <run_name_or_id> with --graceful flag (defaults to force stop)

Base Orchestrator Framework

  • Extended BaseOrchestrator with supports_cancellation property and abstract stop_run() method
  • Implemented status validation to prevent stopping finished or already-stopping pipelines
  • Added automatic status transition to STOPPING before calling concrete orchestrator implementations
  • Integrated keyboard interrupt handling for synchronous orchestrators

Kubernetes Orchestrator Implementation

Stop Mechanism

The Kubernetes orchestrator implements two stop modes:

  1. Force Stop (default): Actively terminates all running step pods associated with the pipeline run
  2. Graceful Stop (--graceful flag): Allows the orchestrator pod and running steps to complete naturally without intervention

Technical Implementation

  • Leverages Kubernetes label selectors (zenml-orchestrator-run-id) to identify related step pods
  • Implements pod discovery and termination with configurable grace periods (30 seconds)

Pipeline Cancellation Detection

  • Added check_pipeline_cancellation() function in the Kubernetes orchestrator entrypoint
  • Integrated cancellation checks into the ThreadedDagRunner via the check_fn parameter

Copy link
Contributor

coderabbitai bot commented May 28, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels May 28, 2025
@bcdurak bcdurak marked this pull request as ready for review June 10, 2025 15:51
@bcdurak bcdurak requested review from schustmi and stefannica June 10, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant